Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29596710: Issue 5989 - Migration crash after updating to 1.3.0 (Closed)

Created:
Nov. 3, 2017, 7:05 p.m. by diegocarloslima
Modified:
Nov. 9, 2017, 12:36 p.m.
Reviewers:
anton, jens
CC:
Felix Dahlke, René Jeschke
Visibility:
Public.

Description

Issue 5989 - Migration crash after updating to 1.3.0

Patch Set 1 #

Total comments: 1

Patch Set 2 : Adjusting spacing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M mobile/android/base/java/org/mozilla/gecko/home/HomeConfigPrefsBackend.java View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 3
diegocarloslima
Nov. 3, 2017, 7:06 p.m. (2017-11-03 19:06:50 UTC) #1
jens
https://codereview.adblockplus.org/29596710/diff/29596711/mobile/android/base/java/org/mozilla/gecko/home/HomeConfigPrefsBackend.java File mobile/android/base/java/org/mozilla/gecko/home/HomeConfigPrefsBackend.java (right): https://codereview.adblockplus.org/29596710/diff/29596711/mobile/android/base/java/org/mozilla/gecko/home/HomeConfigPrefsBackend.java#newcode184 mobile/android/base/java/org/mozilla/gecko/home/HomeConfigPrefsBackend.java:184: if(syncIndex == -1) { Minor, but a space between ...
Nov. 4, 2017, 10:47 a.m. (2017-11-04 10:47:27 UTC) #2
anton
Nov. 7, 2017, 7:01 a.m. (2017-11-07 07:01:53 UTC) #3
On 2017/11/03 19:06:50, diegocarloslima wrote:

LGTM

Powered by Google App Engine
This is Rietveld