Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: compiled/subscription/Subscription.cpp

Issue 29600638: Noissue - initialise Subscription::mListed in constructor. (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/
Patch Set: Created Nov. 7, 2017, 10:26 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 11 matching lines...) Expand all
22 #include "DownloadableSubscription.h" 22 #include "DownloadableSubscription.h"
23 #include "UserDefinedSubscription.h" 23 #include "UserDefinedSubscription.h"
24 #include "../StringMap.h" 24 #include "../StringMap.h"
25 25
26 namespace 26 namespace
27 { 27 {
28 StringMap<Subscription*> knownSubscriptions(16); 28 StringMap<Subscription*> knownSubscriptions(16);
29 } 29 }
30 30
31 Subscription::Subscription(Type type, const String& id) 31 Subscription::Subscription(Type type, const String& id)
32 : mID(id), mType(type), mDisabled(false) 32 : mID(id), mType(type), mDisabled(false), mListed(false)
33 { 33 {
34 annotate_address(this, "Subscription"); 34 annotate_address(this, "Subscription");
35 } 35 }
36 36
37 Subscription::~Subscription() 37 Subscription::~Subscription()
38 { 38 {
39 knownSubscriptions.erase(mID); 39 knownSubscriptions.erase(mID);
40 } 40 }
41 41
42 Filter* Subscription::FilterAt(Subscription::Filters::size_type index) 42 Filter* Subscription::FilterAt(Subscription::Filters::size_type index)
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
122 122
123 // This is a hack: we looked up the entry using id but create it using 123 // This is a hack: we looked up the entry using id but create it using
124 // subscription->mID. This works because both are equal at this point. 124 // subscription->mID. This works because both are equal at this point.
125 // However, id refers to a temporary buffer which will go away. 125 // However, id refers to a temporary buffer which will go away.
126 enter_context("Adding to known subscriptions"); 126 enter_context("Adding to known subscriptions");
127 knownSubscription.assign(subscription->mID, subscription.get()); 127 knownSubscription.assign(subscription->mID, subscription.get());
128 exit_context(); 128 exit_context();
129 129
130 return subscription.release(); 130 return subscription.release();
131 } 131 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld