Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29600638: Noissue - initialise Subscription::mListed in constructor. (Closed)

Created:
Nov. 7, 2017, 10:26 p.m. by hub
Modified:
Nov. 8, 2017, 6:48 p.m.
Reviewers:
sergei, Wladimir Palant
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Description

Noissue - initialise Subscription::mListed in constructor.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M compiled/subscription/Subscription.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
hub
Nov. 7, 2017, 10:26 p.m. (2017-11-07 22:26:11 UTC) #1
hub
Nov. 7, 2017, 10:26 p.m. (2017-11-07 22:26:57 UTC) #2
sergei
LGTM, though I would remove this member from the Subscription class.
Nov. 8, 2017, 1:14 p.m. (2017-11-08 13:14:08 UTC) #3
Wladimir Palant
Nov. 8, 2017, 6:48 p.m. (2017-11-08 18:48:40 UTC) #4
Message was sent while issue was closed.
LGTM, and while I understand Sergei's concerns - having this member in the class
seems to be a reasonable optimization to me.

Powered by Google App Engine
This is Rietveld