Issue 29600641: Issue 5175 - Reject element hiding filter with empty domain names

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29600641: Issue 5175 - Reject element hiding filter with empty domain names (Closed)

Created:
Nov. 7, 2017, 11:17 p.m. by hub

Modified:
Nov. 13, 2018, 8:10 p.m.

Reviewers:
sergei

CC:
Oleksandr

Base URL:
https://hg.adblockplus.org/adblockpluscore/

Visibility:
Public.

Issue 5175 - Reject element hiding filter with empty domain names On top of emscripten branch

Created: March 6, 2018, 7:47 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+110 lines, -33 lines)			Patch
M	compiled/filter/ActiveFilter.h	View	1 2	2 chunks	+24 lines, -2 lines	0 comments	Download
M	compiled/filter/ActiveFilter.cpp	View	1 2	1 chunk	+36 lines, -12 lines	0 comments	Download
M	compiled/filter/ElemHideBase.h	View	1 2	1 chunk	+4 lines, -2 lines	0 comments	Download
M	compiled/filter/ElemHideBase.cpp	View	1 2 3	2 chunks	+12 lines, -3 lines	0 comments	Download
M	compiled/filter/ElemHideEmulationFilter.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	compiled/filter/ElemHideEmulationFilter.cpp	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	compiled/filter/ElemHideException.h	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
M	compiled/filter/ElemHideException.cpp	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	compiled/filter/ElemHideFilter.h	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
M	compiled/filter/ElemHideFilter.cpp	View	1 2	1 chunk	+3 lines, -2 lines	0 comments	Download
M	compiled/filter/Filter.cpp	View	1 2 3	2 chunks	+6 lines, -4 lines	0 comments	Download
M	compiled/filter/RegExpFilter.cpp	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	test/filterClasses.js	View	1 2 3 4	1 chunk	+15 lines, -0 lines	0 comments	Download

Total messages: 5

sergei

On 2018/10/31 22:55:49, hub wrote: > Shall we move this review to gitlab? It depends ...

Nov. 5, 2018, 12:22 p.m. (2018-11-05 12:22:28 UTC) #3

hub

On 2018/11/05 12:22:28, sergei wrote: > On 2018/10/31 22:55:49, hub wrote: > > Shall we ...

Nov. 13, 2018, 8:09 p.m. (2018-11-13 20:09:45 UTC) #4

hub

Nov. 13, 2018, 8:10 p.m. (2018-11-13 20:10:43 UTC) #5

closing and replacing with
https://gitlab.com/eyeo/adblockplus/adblockpluscore/merge_requests/5