Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(246)

Issue 29600641: Issue 5175 - Reject element hiding filter with empty domain names (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years ago by hub
Modified:
1 year ago
Reviewers:
sergei
CC:
Oleksandr
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Description

Issue 5175 - Reject element hiding filter with empty domain names On top of emscripten branch

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Rebased #

Patch Set 4 : Rebased patch. #

Patch Set 5 : Make the new test more functional #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -33 lines) Patch
M compiled/filter/ActiveFilter.h View 1 2 2 chunks +24 lines, -2 lines 0 comments Download
M compiled/filter/ActiveFilter.cpp View 1 2 1 chunk +36 lines, -12 lines 0 comments Download
M compiled/filter/ElemHideBase.h View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M compiled/filter/ElemHideBase.cpp View 1 2 3 2 chunks +12 lines, -3 lines 0 comments Download
M compiled/filter/ElemHideEmulationFilter.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M compiled/filter/ElemHideEmulationFilter.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M compiled/filter/ElemHideException.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M compiled/filter/ElemHideException.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M compiled/filter/ElemHideFilter.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M compiled/filter/ElemHideFilter.cpp View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M compiled/filter/Filter.cpp View 1 2 3 2 chunks +6 lines, -4 lines 0 comments Download
M compiled/filter/RegExpFilter.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M test/filterClasses.js View 1 2 3 4 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 5
hub
2 years ago (2017-11-07 23:17:46 UTC) #1
hub
Shall we move this review to gitlab?
1 year, 1 month ago (2018-10-31 22:55:49 UTC) #2
sergei
On 2018/10/31 22:55:49, hub wrote: > Shall we move this review to gitlab? It depends ...
1 year, 1 month ago (2018-11-05 12:22:28 UTC) #3
hub
On 2018/11/05 12:22:28, sergei wrote: > On 2018/10/31 22:55:49, hub wrote: > > Shall we ...
1 year ago (2018-11-13 20:09:45 UTC) #4
hub
1 year ago (2018-11-13 20:10:43 UTC) #5
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5