Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29602557: Issue 5852 - Change hover/focus/active colour for accordion menu on help.eyeo.com (Closed)

Created:
Nov. 9, 2017, 9:29 a.m. by ire
Modified:
Nov. 10, 2017, 12:01 p.m.
Reviewers:
juliandoucette
Base URL:
https://hg.adblockplus.org/help.eyeo.com
Visibility:
Public.

Description

Issue 5852 - Change hover/focus/active colour for accordion menu on help.eyeo.com

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M static/scss/base/_variables.scss View 1 chunk +1 line, -1 line 2 comments Download
M static/scss/components/_accordion.scss View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
ire
Nov. 9, 2017, 9:29 a.m. (2017-11-09 09:29:58 UTC) #1
ire
Ready. Side note: I know I previously said I would handle the hover/focus/active state for ...
Nov. 9, 2017, 9:32 a.m. (2017-11-09 09:32:58 UTC) #2
juliandoucette
I'm still not a fan. I'll approve it Jeen or Martin approves. But I don't ...
Nov. 9, 2017, 2:13 p.m. (2017-11-09 14:13:50 UTC) #3
ire
On 2017/11/09 14:13:50, juliandoucette wrote: > I'm still not a fan. I'll approve it Jeen ...
Nov. 9, 2017, 2:41 p.m. (2017-11-09 14:41:46 UTC) #4
juliandoucette
Nov. 10, 2017, 10:44 a.m. (2017-11-10 10:44:36 UTC) #5
> Maybe talk to Jeen about it then? She's the one that gave this colour.

LGTM

I may create a ticket about it later.

Powered by Google App Engine
This is Rietveld