Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(204)

Issue 29602561: Issue 5817 - Make sure to send initialization message to the Block Element pop-up only after it is … (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 11 months ago by Wladimir Palant
Modified:
1 year, 11 months ago
Reviewers:
kzar
CC:
Sebastian Noack
Base URL:
https://hg.adblockplus.org/adblockpluschrome
Visibility:
Public.

Description

Issue 5817 - Make sure to send initialization message to the Block Element pop-up only after it is initialized

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -14 lines) Patch
M composer.postload.js View 1 chunk +3 lines, -9 lines 0 comments Download
M lib/filterComposer.js View 1 chunk +29 lines, -5 lines 2 comments Download

Messages

Total messages: 3
Wladimir Palant
1 year, 11 months ago (2017-11-09 14:11:29 UTC) #1
Wladimir Palant
Note that I saw the issue on Chrome as well. Not sure why it didn't ...
1 year, 11 months ago (2017-11-09 14:14:12 UTC) #2
kzar
1 year, 11 months ago (2017-11-10 14:51:50 UTC) #3
LGTM

(Sorry, not sure how I missed this review yesterday.)

https://codereview.adblockplus.org/29602561/diff/29602562/lib/filterComposer.js
File lib/filterComposer.js (right):

https://codereview.adblockplus.org/29602561/diff/29602562/lib/filterComposer....
lib/filterComposer.js:252: let onRemoved = removedTabId =>
On 2017/11/09 14:14:12, Wladimir Palant wrote:
> The changes after this line aren't strictly necessary, I simply wanted to keep
> it consistent and to remove ext usage.

Acknowledged.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5