Issue 29602561: Issue 5817 - Make sure to send initialization message to the Block Element pop-up only after it is …

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29602561: Issue 5817 - Make sure to send initialization message to the Block Element pop-up only after it is … (Closed)

Created:
Nov. 9, 2017, 2:11 p.m. by Wladimir Palant

Modified:
Nov. 10, 2017, 6:28 p.m.

Reviewers:
kzar

CC:
Sebastian Noack

Base URL:
https://hg.adblockplus.org/adblockpluschrome

Visibility:
Public.

Description

Issue 5817 - Make sure to send initialization message to the Block Element pop-up only after it is initialized

Patch Set 1 #

Total comments: 2

Created: Nov. 9, 2017, 2:11 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -14 lines)			Patch
	M	composer.postload.js	View		1 chunk	+3 lines, -9 lines	0 comments	Download
	M	lib/filterComposer.js	View		1 chunk	+29 lines, -5 lines	2 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Wladimir Palant

Note that I saw the issue on Chrome as well. Not sure why it didn't ...

Nov. 9, 2017, 2:14 p.m. (2017-11-09 14:14:12 UTC) #2

kzar

Nov. 10, 2017, 2:51 p.m. (2017-11-10 14:51:50 UTC) #3

LGTM

(Sorry, not sure how I missed this review yesterday.)

https://codereview.adblockplus.org/29602561/diff/29602562/lib/filterComposer.js
File lib/filterComposer.js (right):

https://codereview.adblockplus.org/29602561/diff/29602562/lib/filterComposer....
lib/filterComposer.js:252: let onRemoved = removedTabId =>
On 2017/11/09 14:14:12, Wladimir Palant wrote:
> The changes after this line aren't strictly necessary, I simply wanted to keep
> it consistent and to remove ext usage.

Acknowledged.

Expand All Messages | Collapse All Messages