Issue 29602570: Issue 6010 - Ignore requests initiated by the browser or extensions

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29602570: Issue 6010 - Ignore requests initiated by the browser or extensions (Closed)

Created:
Nov. 9, 2017, 4:17 p.m. by Wladimir Palant

Modified:
Nov. 10, 2017, 10:07 a.m.

Reviewers:
kzar

CC:
Sebastian Noack

Base URL:
https://hg.adblockplus.org/adblockpluschrome

Visibility:
Public.

Description

Issue 6010 - Ignore requests initiated by the browser or extensions

Patch Set 1 #

Created: Nov. 9, 2017, 4:17 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -0 lines)			Patch
	M	ext/background.js	View		1 chunk	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

kzar

There are some other listeners for the event, in popupBlocker.js and devtools.js. Do we need ...

Nov. 9, 2017, 4:22 p.m. (2017-11-09 16:22:21 UTC) #2

Wladimir Palant

On 2017/11/09 16:22:21, kzar wrote: > There are some other listeners for the event, in ...

Nov. 9, 2017, 4:39 p.m. (2017-11-09 16:39:04 UTC) #3

kzar

Nov. 9, 2017, 4:40 p.m. (2017-11-09 16:40:00 UTC) #4

On 2017/11/09 16:39:04, Wladimir Palant wrote:
> On 2017/11/09 16:22:21, kzar wrote:
> > There are some other listeners for the event, in popupBlocker.js and
> > devtools.js. Do we need to add this clause to those too?
> 
> Don't think so. The listener in devtools.js is only there to recognize when a
> panel needs reloading, it will ignore requests with tabId -1 anyway. And the
one
> in popupBlocker.js listens only to main_frame requests.

Cool OK, LGTM.

Expand All Messages | Collapse All Messages