Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29602805: Noissue - Remove bare exceptions from test cases (Closed)

Created:
Nov. 9, 2017, 11:50 p.m. by rosie
Modified:
Nov. 20, 2017, 2:52 a.m.
Reviewers:
Sebastian Noack, tlucas
CC:
Vasily Kuznetsov
Base URL:
https://hg.adblockplus.org/codingtools/
Visibility:
Public.

Description

A recent version of flake8 upstream introduced an error for bare exceptions (E722). There were four test cases that needed to be updated for compliance.

Patch Set 1 #

Patch Set 2 : Removed .orig files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M flake8-eyeo/tests/A202.py View 1 chunk +1 line, -1 line 0 comments Download
M flake8-eyeo/tests/A204.py View 1 chunk +1 line, -1 line 0 comments Download
M flake8-eyeo/tests/A205.py View 1 chunk +1 line, -1 line 0 comments Download
M flake8-eyeo/tests/A206.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6
rosie
Nov. 9, 2017, 11:50 p.m. (2017-11-09 23:50:09 UTC) #1
Sebastian Noack
Mind removing the *.orig files?
Nov. 9, 2017, 11:55 p.m. (2017-11-09 23:55:44 UTC) #2
rosie
On 2017/11/09 23:55:44, Sebastian Noack wrote: > Mind removing the *.orig files? done
Nov. 10, 2017, 12:07 a.m. (2017-11-10 00:07:46 UTC) #3
Sebastian Noack
LGTM
Nov. 10, 2017, 12:09 a.m. (2017-11-10 00:09:08 UTC) #4
tlucas
Hey Rose! Also LGTM
Nov. 10, 2017, 9:14 a.m. (2017-11-10 09:14:38 UTC) #5
Sebastian Noack
Nov. 15, 2017, 10:44 p.m. (2017-11-15 22:44:55 UTC) #6
I merged this change: https://hg.adblockplus.org/codingtools/rev/0fea95fb24ac

You can close this review, now.

Powered by Google App Engine
This is Rietveld