Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(793)

Issue 29602819: Issue 5844 - Detect (more) redundant parentheses

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month ago by rosie
Modified:
7 hours, 1 minute ago
Reviewers:
Sebastian Noack, tlucas
Base URL:
https://hg.adblockplus.org/codingtools/
Visibility:
Public.

Description

Issue 5844 - Detect (more) redundant parentheses

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix format errors on test case #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -40 lines) Patch
M flake8-eyeo/flake8_eyeo.py View 1 2 chunks +59 lines, -40 lines 0 comments Download
M flake8-eyeo/tests/A111.py View 1 2 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 4
rosie
1 month ago (2017-11-10 00:26:10 UTC) #1
tlucas
https://codereview.adblockplus.org/29602819/diff/29602820/flake8-eyeo/tests/A111.py File flake8-eyeo/tests/A111.py (right): https://codereview.adblockplus.org/29602819/diff/29602820/flake8-eyeo/tests/A111.py#newcode15 flake8-eyeo/tests/A111.py:15: # * A111 If i'm not mistaken, the *'s ...
4 weeks, 1 day ago (2017-11-15 09:06:17 UTC) #2
rosie
https://codereview.adblockplus.org/29602819/diff/29602820/flake8-eyeo/tests/A111.py File flake8-eyeo/tests/A111.py (right): https://codereview.adblockplus.org/29602819/diff/29602820/flake8-eyeo/tests/A111.py#newcode15 flake8-eyeo/tests/A111.py:15: # * A111 On 2017/11/15 09:06:17, tlucas wrote: > ...
1 week ago (2017-12-07 01:51:26 UTC) #3
tlucas
7 hours, 1 minute ago (2017-12-14 10:13:13 UTC) #4
On 2017/12/07 01:51:26, rosie wrote:
>
https://codereview.adblockplus.org/29602819/diff/29602820/flake8-eyeo/tests/A...
> File flake8-eyeo/tests/A111.py (right):
> 
>
https://codereview.adblockplus.org/29602819/diff/29602820/flake8-eyeo/tests/A...
> flake8-eyeo/tests/A111.py:15: #     * A111
> On 2017/11/15 09:06:17, tlucas wrote:
> > If i'm not mistaken, the *'s column should match the opening parentheses'
> > column, same below 
> 
> Done.

LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5