Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(54)

Issue 29602819: Issue 5844 - Detect (more) redundant parentheses (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 months, 1 week ago by rosie
Modified:
5 months, 3 weeks ago
Reviewers:
Sebastian Noack, tlucas
CC:
Vasily Kuznetsov
Base URL:
https://hg.adblockplus.org/codingtools/
Visibility:
Public.

Description

Issue 5844 - Detect (more) redundant parentheses

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix format errors on test case #

Patch Set 3 : Updated README, and tested the changes on existing code #

Patch Set 4 : Updated flake8-eyeo/README.md and applied patches to existing codebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -41 lines) Patch
M flake8-eyeo/README.md View 2 1 chunk +1 line, -1 line 0 comments Download
M flake8-eyeo/flake8_eyeo.py View 1 2 chunks +59 lines, -40 lines 0 comments Download
M flake8-eyeo/tests/A111.py View 1 2 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 9
rosie
8 months, 1 week ago (2017-11-10 00:26:10 UTC) #1
tlucas
https://codereview.adblockplus.org/29602819/diff/29602820/flake8-eyeo/tests/A111.py File flake8-eyeo/tests/A111.py (right): https://codereview.adblockplus.org/29602819/diff/29602820/flake8-eyeo/tests/A111.py#newcode15 flake8-eyeo/tests/A111.py:15: # * A111 If i'm not mistaken, the *'s ...
8 months ago (2017-11-15 09:06:17 UTC) #2
rosie
https://codereview.adblockplus.org/29602819/diff/29602820/flake8-eyeo/tests/A111.py File flake8-eyeo/tests/A111.py (right): https://codereview.adblockplus.org/29602819/diff/29602820/flake8-eyeo/tests/A111.py#newcode15 flake8-eyeo/tests/A111.py:15: # * A111 On 2017/11/15 09:06:17, tlucas wrote: > ...
7 months, 2 weeks ago (2017-12-07 01:51:26 UTC) #3
tlucas
On 2017/12/07 01:51:26, rosie wrote: > https://codereview.adblockplus.org/29602819/diff/29602820/flake8-eyeo/tests/A111.py > File flake8-eyeo/tests/A111.py (right): > > https://codereview.adblockplus.org/29602819/diff/29602820/flake8-eyeo/tests/A111.py#newcode15 > ...
7 months ago (2017-12-14 10:13:13 UTC) #4
rosie
On 2017/12/14 10:13:13, tlucas wrote: > On 2017/12/07 01:51:26, rosie wrote: > > > https://codereview.adblockplus.org/29602819/diff/29602820/flake8-eyeo/tests/A111.py ...
6 months ago (2018-01-14 01:01:31 UTC) #5
tlucas
On 2018/01/14 01:01:31, rosie wrote: > On 2017/12/14 10:13:13, tlucas wrote: > > On 2017/12/07 ...
6 months ago (2018-01-14 01:19:36 UTC) #6
Sebastian Noack
The README still needs to be updated. Also before landing this change, we should run ...
6 months ago (2018-01-14 02:01:05 UTC) #7
rosie
On 2018/01/14 02:01:05, Sebastian Noack wrote: > The README still needs to be updated. > ...
5 months, 3 weeks ago (2018-01-25 19:36:17 UTC) #8
Sebastian Noack
5 months, 3 weeks ago (2018-01-25 19:44:22 UTC) #9
Thanks, LGTM!

However, we should land the other patches, adapting for this change, in the
projects using flake8-eyeo, first. Otherwise, we will create a temporary
situation, in which flake8/tox will fail for these projects.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5