Issue 5844 - Detect (more) redundant parentheses

Issue 5844 - Detect (more) redundant parentheses

[tlucas, 2017-11-15 09:06:17]

https://codereview.adblockplus.org/29602819/diff/29602820/flake8-eyeo/tests/A...
File flake8-eyeo/tests/A111.py (right):

https://codereview.adblockplus.org/29602819/diff/29602820/flake8-eyeo/tests/A...
flake8-eyeo/tests/A111.py:15: #     * A111
If i'm not mistaken, the *'s column should match the opening parentheses'
column, same below

[rosie, 2017-12-07 01:51:26]

https://codereview.adblockplus.org/29602819/diff/29602820/flake8-eyeo/tests/A...
File flake8-eyeo/tests/A111.py (right):

https://codereview.adblockplus.org/29602819/diff/29602820/flake8-eyeo/tests/A...
flake8-eyeo/tests/A111.py:15: #     * A111
On 2017/11/15 09:06:17, tlucas wrote:
> If i'm not mistaken, the *'s column should match the opening parentheses'
> column, same below 

Done.

[tlucas, 2017-12-14 10:13:13]

On 2017/12/07 01:51:26, rosie wrote:
>
https://codereview.adblockplus.org/29602819/diff/29602820/flake8-eyeo/tests/A...
> File flake8-eyeo/tests/A111.py (right):
> 
>
https://codereview.adblockplus.org/29602819/diff/29602820/flake8-eyeo/tests/A...
> flake8-eyeo/tests/A111.py:15: #     * A111
> On 2017/11/15 09:06:17, tlucas wrote:
> > If i'm not mistaken, the *'s column should match the opening parentheses'
> > column, same below 
> 
> Done.

LGTM

[rosie, 2018-01-14 01:01:31]

On 2017/12/14 10:13:13, tlucas wrote:
> On 2017/12/07 01:51:26, rosie wrote:
> >
>
https://codereview.adblockplus.org/29602819/diff/29602820/flake8-eyeo/tests/A...
> > File flake8-eyeo/tests/A111.py (right):
> > 
> >
>
https://codereview.adblockplus.org/29602819/diff/29602820/flake8-eyeo/tests/A...
> > flake8-eyeo/tests/A111.py:15: #     * A111
> > On 2017/11/15 09:06:17, tlucas wrote:
> > > If i'm not mistaken, the *'s column should match the opening parentheses'
> > > column, same below 
> > 
> > Done.
> 
> LGTM

Should this be merged and closed then? Or should someone else review it?

[tlucas, 2018-01-14 01:19:36]

On 2018/01/14 01:01:31, rosie wrote:
> On 2017/12/14 10:13:13, tlucas wrote:
> > On 2017/12/07 01:51:26, rosie wrote:
> > >
> >
>
https://codereview.adblockplus.org/29602819/diff/29602820/flake8-eyeo/tests/A...
> > > File flake8-eyeo/tests/A111.py (right):
> > > 
> > >
> >
>
https://codereview.adblockplus.org/29602819/diff/29602820/flake8-eyeo/tests/A...
> > > flake8-eyeo/tests/A111.py:15: #     * A111
> > > On 2017/11/15 09:06:17, tlucas wrote:
> > > > If i'm not mistaken, the *'s column should match the opening
parentheses'
> > > > column, same below 
> > > 
> > > Done.
> > 
> > LGTM
> 
> Should this be merged and closed then? Or should someone else review it?

Imho we're good to go - to be extra sure, we could wait for Sebastian's oppinion
:)

[Sebastian Noack, 2018-01-14 02:01:05]

The README still needs to be updated.

Also before landing this change, we should run flake8-eyeo with this patch on
our existing code (i.e. sitescripts, abpsemmbly, buildtools, cms,
codingtools/patchconv, python-abp) and prepare patches for the required changes
there, 1. In order to validate that the result of this change is desired, 2.
since this change might break flake8/tox for these projects and we should avoid
that situation.

[rosie, 2018-01-25 19:36:17]

On 2018/01/14 02:01:05, Sebastian Noack wrote:
> The README still needs to be updated.
> 
> Also before landing this change, we should run flake8-eyeo with this patch on
> our existing code (i.e. sitescripts, abpsemmbly, buildtools, cms,
> codingtools/patchconv, python-abp) and prepare patches for the required
changes
> there, 1. In order to validate that the result of this change is desired, 2.
> since this change might break flake8/tox for these projects and we should
avoid
> that situation.

Updated the README. Also ran flake8-eyeo on the existing code and applied
patches
for the required changes.

[Sebastian Noack, 2018-01-25 19:44:22]

Thanks, LGTM!

However, we should land the other patches, adapting for this change, in the
projects using flake8-eyeo, first. Otherwise, we will create a temporary
situation, in which flake8/tox will fail for these projects.