Issue 5146 - Implement DownloadableSubscription parsing in C++

compiled/String.h

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 173 matching lines @@
       // This should be more efficient with a lookup table but I couldn't measure
       // any performance difference.
       if (currChar >= u'A' && currChar <= u'Z')
         mBuf[i] = currChar + u'a' - u'A';
       else if (currChar >= 128)
       {
         mBuf[i] = CharToLower(currChar);
       }
     }
   }
+
+  int toInt() const
+  {

[hub, 2017/11/27 17:15:44]

This is redundant with some of the changes in
https://codereview.adblockplus.org/29548581/

+    size_type count = 0;
+    int value = 0;
+    for (size_type i = 0; i < length(); i++)
+    {
+      if (mBuf[i] < u'0' || mBuf[i] > u'9')
+        return 0;
+      value *= 10;
+      value += mBuf[i] - u'0';
+      count++;
+      if (count > 8)
+        return 0;
+    }
+    return value;
+  }
 };
 
 class DependentString : public String
 {
 public:
   explicit DependentString()
       : String(nullptr, 0, INVALID)
   {
   }
 
@@ skipping 194 matching lines @@
     if (negative)
       mBuf[pos++] = '-';
 
     for (int i = size - 1; i >= 0; i--)
     {
       mBuf[pos + i] = '0' + (num % 10);
       num /= 10;
     }
   }
 };