Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code
Issues
All Issues

Issue 29606600: Issue 5146 - Implement DownloadableSubscription parsing in C++ (Closed)

Created:
Nov. 13, 2017, 10:25 p.m. by hub
Modified:
Nov. 13, 2018, 8:15 p.m.
Reviewers:
sergei
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Description

Issue 5146 - Implement DownloadableSubscription parsing in C++ On top of: https://codereview.adblockplus.org/29600641/

Patch Set 1 #

Total comments: 7

Patch Set 2 : Added md5 checksum. Reorganized some code. #

Patch Set 3 : Now all test pass (almost unchanged). Addressed many issues. #

Patch Set 4 : Simplify the logic of Process() #

Patch Set 5 : Improved logic for Process() #

Patch Set 6 : Latest changes #

Patch Set 7 : Rebased #

Patch Set 8 : Fix the UTF-8 encoding used for MD5. #

Patch Set 9 : Removed Md5sum and associated code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+825 lines, -93 lines) Patch
M compiled/FilterNotifier.h View 1 2 3 4 5 6 7 8 2 chunks +4 lines, -0 lines 0 comments Download
M compiled/StringScanner.h View 1 2 3 4 5 6 7 8 1 chunk +6 lines, -0 lines 0 comments Download
M compiled/bindings/main.cpp View 1 2 3 4 5 6 7 8 1 chunk +9 lines, -1 line 0 comments Download
M compiled/storage/FilterStorage.h View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -0 lines 0 comments Download
M compiled/storage/FilterStorage.cpp View 1 2 3 4 5 6 7 8 1 chunk +10 lines, -0 lines 0 comments Download
M compiled/subscription/DownloadableSubscription.h View 1 2 3 4 5 6 7 8 2 chunks +25 lines, -2 lines 0 comments Download
M compiled/subscription/DownloadableSubscription.cpp View 1 2 3 4 5 6 7 8 1 chunk +212 lines, -0 lines 0 comments Download
M compiled/subscription/Subscription.h View 1 2 3 4 5 6 7 8 1 chunk +10 lines, -0 lines 0 comments Download
M lib/synchronizer.js View 1 2 3 4 5 6 7 8 3 chunks +22 lines, -81 lines 0 comments Download
M test/stub-modules/utils.js View 1 2 1 chunk +0 lines, -9 lines 0 comments Download
A test/synchronizer.js View 1 2 3 4 5 6 7 8 1 chunk +525 lines, -0 lines 0 comments Download

Messages

Total messages: 6
hub
Nov. 13, 2017, 10:25 p.m. (2017-11-13 22:25:11 UTC) #1
hub
This is still a draft version of this patch. I stash it for now it ...
Nov. 13, 2017, 10:27 p.m. (2017-11-13 22:27:15 UTC) #2
hub
The known issues. https://codereview.adblockplus.org/29606600/diff/29606601/compiled/filter/CommentFilter.cpp File compiled/filter/CommentFilter.cpp (right): https://codereview.adblockplus.org/29606600/diff/29606601/compiled/filter/CommentFilter.cpp#newcode25 compiled/filter/CommentFilter.cpp:25: bool foundColon = false; this is ...
Nov. 13, 2017, 10:35 p.m. (2017-11-13 22:35:28 UTC) #3
hub
https://codereview.adblockplus.org/29606600/diff/29606601/compiled/String.h File compiled/String.h (right): https://codereview.adblockplus.org/29606600/diff/29606601/compiled/String.h#newcode196 compiled/String.h:196: { This is redundant with some of the changes ...
Nov. 27, 2017, 5:15 p.m. (2017-11-27 17:15:45 UTC) #4
hub
need to remove the md5 sum code since it is being deprecated as per issue ...
Aug. 14, 2018, 3:41 a.m. (2018-08-14 03:41:11 UTC) #5
hub
Nov. 13, 2018, 8:15 p.m. (2018-11-13 20:15:48 UTC) #6

Powered by Google App Engine
This is Rietveld