Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: pages/uninstalled-submit.html

Issue 29611624: Issue 6047 - Updated templates and uninstalled pages (Closed) Base URL: https://hg.adblockplus.org/web.adblockplus.org
Patch Set: Changed document macro in html-attribute include, removed simple template, and removed temporary/unused resources include Created Nov. 25, 2017, 1:35 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pages/uninstalled-submit.html
===================================================================
rename from pages/uninstalled-submit.md
rename to pages/uninstalled-submit.html
--- a/pages/uninstalled-submit.md
+++ b/pages/uninstalled-submit.html
@@ -1,22 +1,22 @@
title=Adblock Plus has been uninstalled
-template=simple
+template=minimal
<head>
<meta name="robots" content="noindex" />
+ <link rel="stylesheet" href="/css/uninstalled.css" type="text/css" media="all">
</head>
-<p class="notification">
- <strong>
- {{ reinstall-headline[Text next to the Reinstallation button] Did you uninstall Adblock Plus by accident? }}
- </strong>
- <a href="index">
- {{ reinstall[Reinstall button text] Reinstall Now }}
- </a>
-</p>
+<div class="container content">
+ <h1>{{ heading[Heading text] Data submitted successfully }}</h1>
+ <p>{{ thank-you[Thank you message below heading] Thank you for your participation }}</p>
+</div>
-<section markdown="1" class="highlighted">
-#{{heading[Heading text] Data submitted successfully}}
-
-{{thank-you[Thank you message below heading] Thank you for your participation}}
-{: .subheader }
-</section>
+<aside id="reinstall" class="bg-accent" >
ire 2017/11/27 19:48:20 Suggest: Since this is used on multiple pages, mak
juliandoucette 2017/12/04 13:34:04 Agreed.
ire 2017/12/07 12:36:26 You haven't done this yet.
juliandoucette 2017/12/14 18:35:22 Done.
+ <div class="container content">
+ <p class="lead">
+ {{ reinstall-headline[Text next to the Reinstallation button] Did you uninstall Adblock Plus by accident?" }}
ire 2017/11/27 19:48:20 Unintended quote mark at the end of this sentence
juliandoucette 2017/12/04 13:34:04 Good catch. It's strange that this doesn't show in
juliandoucette 2017/12/06 16:30:52 Done.
+ <a href="index" class="button">
ire 2017/11/27 19:48:21 This button isn't styled correctly
juliandoucette 2017/12/04 13:34:04 Correctly how? I styled it according to Paul's spe
ire 2017/12/05 10:28:00 Sorry I was going off the spec. Is Paul's change d
juliandoucette 2017/12/06 16:05:06 Unfortunately not.
+ {{ reinstall[Reinstall button text] Reinstall Now }}
+ </a>
+ </div>
+</aside>

Powered by Google App Engine
This is Rietveld