Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29613611: Noissue - fix debug build (Closed)

Created:
Nov. 21, 2017, 12:19 p.m. by sergei
Modified:
Nov. 28, 2017, 1:03 p.m.
Reviewers:
hub, Wladimir Palant
Base URL:
https://github.com/adblockplus/adblockpluscore.git
Visibility:
Public.

Description

- define DEBUG when it's debug build - include String.h in intrusive_ptr.h in order to be able to use u""_str - fix parameter types passed to assert2 Review: https://codereview.adblockplus.org/29613611

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M compile View 1 chunk +1 line, -0 lines 0 comments Download
M compiled/intrusive_ptr.h View 1 chunk +1 line, -0 lines 0 comments Download
M compiled/subscription/UserDefinedSubscription.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3
sergei
Nov. 21, 2017, 12:21 p.m. (2017-11-21 12:21:37 UTC) #1
hub
LGTM
Nov. 21, 2017, 1:45 p.m. (2017-11-21 13:45:23 UTC) #2
Wladimir Palant
Nov. 28, 2017, 1:03 p.m. (2017-11-28 13:03:50 UTC) #3
Message was sent while issue was closed.
LGTM

I think this worked before, maybe something changed about our tooling.

Powered by Google App Engine
This is Rietveld