Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29616555: Issue 6082 - Update suport section in the help tab (Closed)

Created:
Nov. 23, 2017, 11:43 a.m. by saroyanm
Modified:
Nov. 24, 2017, 2:27 p.m.
Reviewers:
martin, Thomas Greiner
Visibility:
Public.

Description

Issue 6082 - Update suport section in the help tab

Patch Set 1 #

Total comments: 4

Patch Set 2 : Update accordingly to the specs and merge "Email translaiton" #

Total comments: 2

Patch Set 3 : Keep email translation #

Total comments: 1

Patch Set 4 : Rebased #

Patch Set 5 : General "issue" reporting text #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -24 lines) Patch
M desktop-options.html View 1 2 3 4 2 chunks +4 lines, -8 lines 0 comments Download
M desktop-options.js View 1 2 3 4 1 chunk +0 lines, -8 lines 0 comments Download
M locale/en_US/desktop-options.json View 1 2 3 4 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 8
saroyanm
@Martin, @Thomas: This are again small changes, whoever will have time to have look would ...
Nov. 23, 2017, 11:46 a.m. (2017-11-23 11:46:05 UTC) #1
Thomas Greiner
https://codereview.adblockplus.org/29616555/diff/29616556/desktop-options.html File desktop-options.html (right): https://codereview.adblockplus.org/29616555/diff/29616556/desktop-options.html#newcode324 desktop-options.html:324: </li> It's a pity that we're left with only ...
Nov. 23, 2017, 3:02 p.m. (2017-11-23 15:02:17 UTC) #2
saroyanm
https://codereview.adblockplus.org/29616555/diff/29616556/desktop-options.html File desktop-options.html (right): https://codereview.adblockplus.org/29616555/diff/29616556/desktop-options.html#newcode324 desktop-options.html:324: </li> On 2017/11/23 15:02:17, Thomas Greiner wrote: > It's ...
Nov. 23, 2017, 4:04 p.m. (2017-11-23 16:04:32 UTC) #3
saroyanm
New patch uploaded. https://codereview.adblockplus.org/29616555/diff/29616594/locale/en_US/desktop-options.json File locale/en_US/desktop-options.json (right): https://codereview.adblockplus.org/29616555/diff/29616594/locale/en_US/desktop-options.json#newcode360 locale/en_US/desktop-options.json:360: "message": "Think content or functionality is ...
Nov. 23, 2017, 5:49 p.m. (2017-11-23 17:49:04 UTC) #4
saroyanm
https://codereview.adblockplus.org/29616555/diff/29616594/locale/en_US/desktop-options.json File locale/en_US/desktop-options.json (right): https://codereview.adblockplus.org/29616555/diff/29616594/locale/en_US/desktop-options.json#newcode360 locale/en_US/desktop-options.json:360: "message": "Think content or functionality is being incorrectly blocked ...
Nov. 23, 2017, 5:56 p.m. (2017-11-23 17:56:19 UTC) #5
saroyanm
https://codereview.adblockplus.org/29616555/diff/29616598/locale/en_US/desktop-options.json File locale/en_US/desktop-options.json (right): https://codereview.adblockplus.org/29616555/diff/29616598/locale/en_US/desktop-options.json#newcode360 locale/en_US/desktop-options.json:360: "message": "Think content or functionality is being incorrectly blocked ...
Nov. 24, 2017, 1:37 p.m. (2017-11-24 13:37:49 UTC) #6
saroyanm
Ready for the review
Nov. 24, 2017, 1:50 p.m. (2017-11-24 13:50:35 UTC) #7
Thomas Greiner
Nov. 24, 2017, 2:14 p.m. (2017-11-24 14:14:58 UTC) #8
LGTM but note the typo in the review title

Powered by Google App Engine
This is Rietveld