Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: includes/layout/header.tmpl

Issue 29622565: Issue 6041 - Navbar search field moves after navbar logo is downloaded (Closed) Base URL: https://hg.adblockplus.org/help.eyeo.com
Patch Set: Created Nov. 28, 2017, 9:06 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: includes/layout/header.tmpl
===================================================================
--- a/includes/layout/header.tmpl
+++ b/includes/layout/header.tmpl
@@ -6,17 +6,17 @@
{% set search_label = "Search for help..." %}
{% set search_site = config.get("general", "siteurl") %}
{% endif %}
<header id="site-header" class="navbar {{ 'site-header-minimal' if product_id is not defined }}">
<div class="container large-desktop-width">
<h1 id="site-title">
{{ "index" | linkify() }}
- <img src="/img/png/eyeo-help.png" srcset="/img/svg/eyeo-help.svg 2x" alt="{{ "eyeo Help" | translate("site-title", "Image alt text") }}">
+ <img src="/img/png/eyeo-help.png" srcset="/img/svg/eyeo-help.svg 2x" alt="{{ "eyeo Help" | translate("site-title", "Image alt text") }}" height="30" width="205">
juliandoucette 2017/11/28 14:55:16 NIT: I think that you could use em inside of your
ire 2017/11/28 16:13:49 Wasn't the point to put these values in HTML? AFAI
</a>
</h1>
<button class="toggle-navbar-collapse unstyled phablet-and-mobile-only">
<img src="/img/png/search-icon.png" srcset="/img/svg/search-icon.svg 2x" alt="{{ "Toggle Search Bar" | translate("search-toggle-alt", "Image alt text") }}">
</button>
<div class="navbar-collapse">
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld