Issue 29626577: Issue 6108 - No filter list is selected after a migration failure

Issue 29626577: Issue 6108 - No filter list is selected after a migration failure (Closed)

Created:
Dec. 1, 2017, 8:24 p.m. by diegocarloslima

Modified:
Dec. 5, 2017, 3:59 p.m.

Reviewers:
anton, jens

CC:
René Jeschke

Visibility:
Public.

Description

Issue 6108 - No filter list is selected after a migration failure

Patch Set 2 : Adding USER_REMOVED_EXCEPTIONS_SUB_PREF #

Patch Set 3 : Small adjustments #

Created: Dec. 5, 2017, 3:51 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+90 lines, -9 lines)			Patch
M	adblockplus/Api.jsm	View	1 2	3 chunks	+42 lines, -7 lines	0 comments	Download
M	adblockplus/build.py	View		2 chunks	+6 lines, -2 lines	0 comments	Download
A	adblockplus/issue-6108.patch	View		1 chunk	+42 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

jens

I have only one minor note https://codereview.adblockplus.org/29626577/diff/29626578/adblockplus/Api.jsm File adblockplus/Api.jsm (right): https://codereview.adblockplus.org/29626577/diff/29626578/adblockplus/Api.jsm#newcode110 adblockplus/Api.jsm:110: (subscription) => subscription ...

Dec. 4, 2017, 11 a.m. (2017-12-04 11:00:30 UTC) #2

anton

https://codereview.adblockplus.org/29626577/diff/29626578/adblockplus/Api.jsm File adblockplus/Api.jsm (right): https://codereview.adblockplus.org/29626577/diff/29626578/adblockplus/Api.jsm#newcode65 adblockplus/Api.jsm:65: if(Prefs.currentVersion == addonVersion && detectedSubscriptionFailure) space is needed here

Dec. 4, 2017, 2 p.m. (2017-12-04 14:00:46 UTC) #3

anton

On 2017/12/04 14:00:46, anton wrote: > https://codereview.adblockplus.org/29626577/diff/29626578/adblockplus/Api.jsm > File adblockplus/Api.jsm (right): > > https://codereview.adblockplus.org/29626577/diff/29626578/adblockplus/Api.jsm#newcode65 > ...

Dec. 4, 2017, 2:20 p.m. (2017-12-04 14:20:07 UTC) #4

diegocarloslima

Dec. 5, 2017, 9:44 a.m. (2017-12-05 09:44:10 UTC) #5

jens

Dec. 5, 2017, 11:24 a.m. (2017-12-05 11:24:15 UTC) #6

On 2017/12/05 09:44:10, diegocarloslima wrote:
> https://codereview.adblockplus.org/29626577/diff/29626578/adblockplus/Api.jsm
> File adblockplus/Api.jsm (right):
> 
>
https://codereview.adblockplus.org/29626577/diff/29626578/adblockplus/Api.jsm...
> adblockplus/Api.jsm:65: if(Prefs.currentVersion == addonVersion &&
> detectedSubscriptionFailure)
> On 2017/12/04 14:00:46, anton wrote:
> > space is needed here
> 
> Acknowledged.
> 
>
https://codereview.adblockplus.org/29626577/diff/29626578/adblockplus/Api.jsm...
> adblockplus/Api.jsm:110: (subscription) => subscription instanceof
> DownloadableSubscription && subscription.url !=
> Prefs.subscriptions_exceptionsurl);
> On 2017/12/04 11:00:30, jens wrote:
> > Do we need parentheses when there's only one parameter name?
> 
> Acknowledged.

LGTM

Expand All Messages | Collapse All Messages