Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(714)

Issue 29628702: Issue 6076 - Remove old search engine ordering logic (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 3 days ago by jens
Modified:
6 days, 1 hour ago
Reviewers:
anton, diegocarloslima
Visibility:
Public.

Description

The way how search engines are selected and sorted ​changed in Firefox 55. Due to this change we have to remove the old logic of ordering search engines for the ABB merge with Fennec 56. Running the build with this changes keeps the search engine order like it is in Firefox.

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Removed obsolete shutil import #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -171 lines) Patch
R mozharness/abb/ecosia.xml View 1 chunk +0 lines, -29 lines 0 comments Download
M mozharness/abb/transform_locales.py View 1 2 chunks +0 lines, -142 lines 0 comments Download

Messages

Total messages: 6
jens
1 week, 3 days ago (2017-12-04 09:10:34 UTC) #1
anton
On 2017/12/04 09:10:34, jens wrote: LGTM
1 week, 3 days ago (2017-12-04 14:15:18 UTC) #2
diegocarloslima
https://codereview.adblockplus.org/29628702/diff/29628715/mozharness/abb/transform_locales.py File mozharness/abb/transform_locales.py (left): https://codereview.adblockplus.org/29628702/diff/29628715/mozharness/abb/transform_locales.py#oldcode18 mozharness/abb/transform_locales.py:18: import shutil This seems to not be required anymore
1 week, 2 days ago (2017-12-05 10:09:40 UTC) #3
jens
https://codereview.adblockplus.org/29628702/diff/29628715/mozharness/abb/transform_locales.py File mozharness/abb/transform_locales.py (left): https://codereview.adblockplus.org/29628702/diff/29628715/mozharness/abb/transform_locales.py#oldcode18 mozharness/abb/transform_locales.py:18: import shutil On 2017/12/05 10:09:40, diegocarloslima wrote: > This ...
1 week, 2 days ago (2017-12-05 10:46:09 UTC) #4
jens
On 2017/12/05 10:46:09, jens wrote: > https://codereview.adblockplus.org/29628702/diff/29628715/mozharness/abb/transform_locales.py > File mozharness/abb/transform_locales.py (left): > > https://codereview.adblockplus.org/29628702/diff/29628715/mozharness/abb/transform_locales.py#oldcode18 > ...
1 week, 2 days ago (2017-12-05 10:48:23 UTC) #5
diegocarloslima
1 week, 2 days ago (2017-12-05 14:47:37 UTC) #6
On 2017/12/05 10:48:23, jens wrote:
> On 2017/12/05 10:46:09, jens wrote:
> >
>
https://codereview.adblockplus.org/29628702/diff/29628715/mozharness/abb/tran...
> > File mozharness/abb/transform_locales.py (left):
> > 
> >
>
https://codereview.adblockplus.org/29628702/diff/29628715/mozharness/abb/tran...
> > mozharness/abb/transform_locales.py:18: import shutil
> > On 2017/12/05 10:09:40, diegocarloslima wrote:
> > > This seems to not be required anymore
> > 
> > Acknowledged.
> 
> I added a new patch set

LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5