Issue 29628702: Issue 6076 - Remove old search engine ordering logic

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29628702: Issue 6076 - Remove old search engine ordering logic (Closed)

Created:
Dec. 4, 2017, 8:55 a.m. by jens

Modified:
Dec. 8, 2017, 3:39 p.m.

Reviewers:
diegocarloslima, anton

Visibility:
Public.

Description

The way how search engines are selected and sorted changed in Firefox 55. Due to this change we have to remove the old logic of ordering search engines for the ABB merge with Fennec 56. Running the build with this changes keeps the search engine order like it is in Firefox.

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Removed obsolete shutil import #

Created: Dec. 5, 2017, 10:47 a.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -171 lines)			Patch
	R	mozharness/abb/ecosia.xml	View		1 chunk	+0 lines, -29 lines	0 comments	Download
	M	mozharness/abb/transform_locales.py	View	1	2 chunks	+0 lines, -142 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

diegocarloslima

https://codereview.adblockplus.org/29628702/diff/29628715/mozharness/abb/transform_locales.py File mozharness/abb/transform_locales.py (left): https://codereview.adblockplus.org/29628702/diff/29628715/mozharness/abb/transform_locales.py#oldcode18 mozharness/abb/transform_locales.py:18: import shutil This seems to not be required anymore

Dec. 5, 2017, 10:09 a.m. (2017-12-05 10:09:40 UTC) #3

jens

Dec. 5, 2017, 10:46 a.m. (2017-12-05 10:46:09 UTC) #4

jens

On 2017/12/05 10:46:09, jens wrote: > https://codereview.adblockplus.org/29628702/diff/29628715/mozharness/abb/transform_locales.py > File mozharness/abb/transform_locales.py (left): > > https://codereview.adblockplus.org/29628702/diff/29628715/mozharness/abb/transform_locales.py#oldcode18 > ...

Dec. 5, 2017, 10:48 a.m. (2017-12-05 10:48:23 UTC) #5

diegocarloslima

Dec. 5, 2017, 2:47 p.m. (2017-12-05 14:47:37 UTC) #6

On 2017/12/05 10:48:23, jens wrote:
> On 2017/12/05 10:46:09, jens wrote:
> >
>
https://codereview.adblockplus.org/29628702/diff/29628715/mozharness/abb/tran...
> > File mozharness/abb/transform_locales.py (left):
> > 
> >
>
https://codereview.adblockplus.org/29628702/diff/29628715/mozharness/abb/tran...
> > mozharness/abb/transform_locales.py:18: import shutil
> > On 2017/12/05 10:09:40, diegocarloslima wrote:
> > > This seems to not be required anymore
> > 
> > Acknowledged.
> 
> I added a new patch set

LGTM

Expand All Messages | Collapse All Messages