Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29629555: Noissue - Remove site name from locale file (Closed)

Created:
Dec. 4, 2017, 11:17 a.m. by ire
Modified:
Dec. 4, 2017, 12:52 p.m.
Reviewers:
juliandoucette
Base URL:
https://hg.adblockplus.org/website-defaults
Visibility:
Public.

Description

Noissue - Remove site name from locale file

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
R locales/en/site.json View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 3
ire
Dec. 4, 2017, 11:17 a.m. (2017-12-04 11:17:45 UTC) #1
ire
I removed this because, if it's included and there is no file in the hosting ...
Dec. 4, 2017, 11:18 a.m. (2017-12-04 11:18:28 UTC) #2
juliandoucette
Dec. 4, 2017, 11:54 a.m. (2017-12-04 11:54:23 UTC) #3
On 2017/12/04 11:18:28, ire wrote:
> I removed this because, if it's included and there is no file in the hosting
> website, this default site name is used due to the file sharing functionality.

Ah, I didn't think of this.

LGTM

Powered by Google App Engine
This is Rietveld