Noissue - Add site name suffix to document title on help.eyeo.com

Noissue - Add site name suffix to document title on help.eyeo.com

[juliandoucette, 2017-12-04 13:01:32]

Perhaps this should change to "| ${product} Help Center" when a product is
selected?

[ire, 2017-12-05 11:02:04]

On 2017/12/04 13:01:32, juliandoucette wrote:
> Perhaps this should change to "| ${product} Help Center" when a product is
> selected?

I like this idea. I'll have to change the way this suffix works on
website-defaults first

[ire, 2017-12-05 11:20:29]

On 2017/12/05 11:02:04, ire wrote:
> On 2017/12/04 13:01:32, juliandoucette wrote:
> > Perhaps this should change to "| ${product} Help Center" when a product is
> > selected?
> 
> I like this idea. I'll have to change the way this suffix works on
> website-defaults first

https://codereview.adblockplus.org/29630648

[juliandoucette, 2017-12-05 16:44:40]

Is this still relevant than? (If not, will you close this review?)

[ire, 2017-12-06 09:39:03]

On 2017/12/05 16:44:40, juliandoucette wrote:
> Is this still relevant than? (If not, will you close this review?)

Yes it's still relevant. This review will be about implementing the new change
when it's pushed in website-defaults

[juliandoucette, 2017-12-13 15:07:21]

LGTM - If you push this later, don't forget to fix the exclude suffix variable
name/value.

[ire, 2017-12-13 19:30:15]

https://codereview.adblockplus.org/29629558/diff/29638568/templates/product-h...
File templates/product-home.tmpl (right):

https://codereview.adblockplus.org/29629558/diff/29638568/templates/product-h...
templates/product-home.tmpl:1: title_suffix={{ products[product_id].full_name }}
Variables don't work here :( 

(Or is there some other way to do this I don't know about?)

[juliandoucette, 2017-12-14 12:38:23]

My bad :(

https://codereview.adblockplus.org/29629558/diff/29638568/templates/product-h...
File templates/product-home.tmpl (right):

https://codereview.adblockplus.org/29629558/diff/29638568/templates/product-h...
templates/product-home.tmpl:1: title_suffix={{ products[product_id].full_name }}
On 2017/12/13 19:30:14, ire wrote:
> Variables don't work here :( 
> 
> (Or is there some other way to do this I don't know about?)

Correct, variables don't work in frontmatter.

I think you can do this? (below)

```
{% set product = products[product_id] %}
{% set title_suffix = product.full_name %}
{% extends "templates/minimal" %}
```

If not, perhaps you could:

1. Use an include e.g. `<? include {{ product + '-frontmatter' }} ?>` and set
the appropriate frontmatter for the product inside that include
2. Use a key like "product_name" that you convert to the product's name via
condition inside another template

[ire, 2017-12-14 14:58:11]

On 2017/12/14 12:38:23, juliandoucette wrote:
> My bad :(

Your suggestion worked :)

(Waiting for LGTM before I push)

https://codereview.adblockplus.org/29629558/diff/29638568/templates/product-h...
File templates/product-home.tmpl (right):

https://codereview.adblockplus.org/29629558/diff/29638568/templates/product-h...
templates/product-home.tmpl:1: title_suffix={{ products[product_id].full_name }}
On 2017/12/14 12:38:22, juliandoucette wrote:
> On 2017/12/13 19:30:14, ire wrote:
> > Variables don't work here :( 
> > 
> > (Or is there some other way to do this I don't know about?)
> 
> Correct, variables don't work in frontmatter.
> 
> I think you can do this? (below)
> 
> ```
> {% set product = products[product_id] %}
> {% set title_suffix = product.full_name %}
> {% extends "templates/minimal" %}
> ```

This worked! Thanks.

[juliandoucette, 2017-12-14 15:47:57]

LGTM