Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(62)

Issue 29630555: Issue 6141, 6140 - Adapt to new build.py interface (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 11 months ago by tlucas
Modified:
1 year, 11 months ago
Reviewers:
Wladimir Palant, kzar
CC:
Vasily Kuznetsov, Sebastian Noack
Base URL:
https://hg.adblockplus.org/sitescripts/file/6287fd6aa256
Visibility:
Public.

Description

Issue 6141, 6140 - Adapt to new build.py interface

Patch Set 1 #

Patch Set 2 : Issue 6141, 6140 - Adapt to new build.py interface #

Total comments: 3

Patch Set 3 : NO CHANGE rebase against current master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M .sitescripts.example View 1 2 1 chunk +1 line, -1 line 0 comments Download
M sitescripts/extensions/bin/createNightlies.py View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7
tlucas
Patch Set 1 Adapt internal build.py call (nightly build creation) to new interface
1 year, 11 months ago (2017-12-05 05:11:42 UTC) #1
kzar
Nit: There's a typo in the title "Adapt". Also please could you update the example ...
1 year, 11 months ago (2017-12-05 10:17:46 UTC) #2
tlucas
On 2017/12/05 10:17:46, kzar wrote: > Nit: There's a typo in the title "Adapt". > ...
1 year, 11 months ago (2017-12-05 11:03:56 UTC) #3
kzar
https://codereview.adblockplus.org/29630555/diff/29630645/.sitescripts.example File .sitescripts.example (right): https://codereview.adblockplus.org/29630555/diff/29630645/.sitescripts.example#newcode215 .sitescripts.example:215: adblockplus_command=./build.py -t gecko docs {output_dir} >/dev/null 2>&1 Does this ...
1 year, 11 months ago (2017-12-05 11:06:30 UTC) #4
tlucas
https://codereview.adblockplus.org/29630555/diff/29630645/.sitescripts.example File .sitescripts.example (right): https://codereview.adblockplus.org/29630555/diff/29630645/.sitescripts.example#newcode215 .sitescripts.example:215: adblockplus_command=./build.py -t gecko docs {output_dir} >/dev/null 2>&1 On 2017/12/05 ...
1 year, 11 months ago (2017-12-05 11:09:39 UTC) #5
kzar
LGTM
1 year, 11 months ago (2017-12-05 11:34:32 UTC) #6
Wladimir Palant
1 year, 11 months ago (2017-12-05 12:37:20 UTC) #7
https://codereview.adblockplus.org/29630555/diff/29630645/.sitescripts.example
File .sitescripts.example (right):

https://codereview.adblockplus.org/29630555/diff/29630645/.sitescripts.exampl...
.sitescripts.example:215: adblockplus_command=./build.py -t gecko docs
{output_dir} >/dev/null 2>&1
On 2017/12/05 11:09:38, tlucas wrote:
> No, (on the infrastructure, as i just learned) 'adblockplus' refers to the
> legacy-extension repository which does not have it's buildtools' updated.

Actually, it might be best to remove the adblockplus_* entries to avoid future
confusion.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5