Issue 29630555: Issue 6141, 6140 - Adapt to new build.py interface

Issue 29630555: Issue 6141, 6140 - Adapt to new build.py interface (Closed)

Created:
Dec. 5, 2017, 5:09 a.m. by tlucas

Modified:
Dec. 5, 2017, 12:39 p.m.

Reviewers:
kzar, Wladimir Palant

CC:
Vasily Kuznetsov, Sebastian Noack

Base URL:
https://hg.adblockplus.org/sitescripts/file/6287fd6aa256

Visibility:
Public.

Description

Issue 6141, 6140 - Adapt to new build.py interface

Patch Set 2 : Issue 6141, 6140 - Adapt to new build.py interface #

Total comments: 3

Patch Set 3 : NO CHANGE rebase against current master #

Created: Dec. 5, 2017, 12:34 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	.sitescripts.example	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
	M	sitescripts/extensions/bin/createNightlies.py	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

tlucas

Patch Set 1 Adapt internal build.py call (nightly build creation) to new interface

Dec. 5, 2017, 5:11 a.m. (2017-12-05 05:11:42 UTC) #1

kzar

Nit: There's a typo in the title "Adapt". Also please could you update the example ...

Dec. 5, 2017, 10:17 a.m. (2017-12-05 10:17:46 UTC) #2

tlucas

On 2017/12/05 10:17:46, kzar wrote: > Nit: There's a typo in the title "Adapt". > ...

Dec. 5, 2017, 11:03 a.m. (2017-12-05 11:03:56 UTC) #3

kzar

https://codereview.adblockplus.org/29630555/diff/29630645/.sitescripts.example File .sitescripts.example (right): https://codereview.adblockplus.org/29630555/diff/29630645/.sitescripts.example#newcode215 .sitescripts.example:215: adblockplus_command=./build.py -t gecko docs {output_dir} >/dev/null 2>&1 Does this ...

Dec. 5, 2017, 11:06 a.m. (2017-12-05 11:06:30 UTC) #4

tlucas

Dec. 5, 2017, 11:09 a.m. (2017-12-05 11:09:39 UTC) #5

Wladimir Palant

Dec. 5, 2017, 12:37 p.m. (2017-12-05 12:37:20 UTC) #7

https://codereview.adblockplus.org/29630555/diff/29630645/.sitescripts.example
File .sitescripts.example (right):

https://codereview.adblockplus.org/29630555/diff/29630645/.sitescripts.exampl...
.sitescripts.example:215: adblockplus_command=./build.py -t gecko docs
{output_dir} >/dev/null 2>&1
On 2017/12/05 11:09:38, tlucas wrote:
> No, (on the infrastructure, as i just learned) 'adblockplus' refers to the
> legacy-extension repository which does not have it's buildtools' updated.

Actually, it might be best to remove the adblockplus_* entries to avoid future
confusion.

Expand All Messages | Collapse All Messages