Issue 29630614: [Demo] Issue 6047 - Missing background on uninstallation page

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29630614: [Demo] Issue 6047 - Missing background on uninstallation page (Closed)

Created:
Dec. 5, 2017, 10:25 a.m. by ire

Modified:
Dec. 14, 2017, 8:53 a.m.

Reviewers:
juliandoucette

Base URL:
https://hg.adblockplus.org/web.adblockplus.org

Visibility:
Public.

Description

[Demo] Issue 6047 - Missing background on uninstallation page

Patch Set 1 #

Created: Dec. 5, 2017, 10:25 a.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+556 lines, -620 lines)			Patch
A	includes/footer.tmpl	View	1 chunk	+69 lines, -0 lines	0 comments	Download
A	includes/html-attributes.tmpl	View	1 chunk	+5 lines, -0 lines	0 comments	Download
A	includes/meta/favicon.tmpl	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	includes/meta/social.tmpl	View	1 chunk	+17 lines, -0 lines	0 comments	Download
A	includes/meta/standard.tmpl	View	1 chunk	+8 lines, -0 lines	0 comments	Download
A	includes/navbar.tmpl	View	1 chunk	+38 lines, -0 lines	0 comments	Download
A	includes/polyfills.tmpl	View	1 chunk	+14 lines, -0 lines	0 comments	Download
A	includes/scripts.tmpl	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	includes/styles.tmpl	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	macros/pageitem.tmpl	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	pages/index.tmpl	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pages/uninstalled.tmpl	View	1 chunk	+63 lines, -133 lines	0 comments	Download
A	pages/uninstalled-submit.html	View	1 chunk	+22 lines, -0 lines	0 comments	Download
R	pages/uninstalled-submit.md	View	1 chunk	+0 lines, -22 lines	0 comments	Download
M	static/css/defaults.css	View	2 chunks	+15 lines, -2 lines	0 comments	Download
M	static/css/main.css	View	4 chunks	+89 lines, -1 line	0 comments	Download
R	static/css/simple.css	View	1 chunk	+0 lines, -257 lines	0 comments	Download
A	static/css/uninstalled.css	View	1 chunk	+65 lines, -0 lines	0 comments	Download
A	static/js/uninstalled.js	View	1 chunk	+93 lines, -0 lines	0 comments	Download
M	templates/default.tmpl	View	2 chunks	+11 lines, -162 lines	0 comments	Download
M	templates/minimal.tmpl	View	1 chunk	+20 lines, -3 lines	0 comments	Download
M	templates/raw.tmpl	View	1 chunk	+15 lines, -1 line	0 comments	Download
R	templates/simple.tmpl	View	1 chunk	+0 lines, -38 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

juliandoucette

Not sure what to do with this review. I think we should convert it into ...

Dec. 13, 2017, 3:04 p.m. (2017-12-13 15:04:07 UTC) #2

juliandoucette

On 2017/12/13 15:04:07, juliandoucette wrote: > Not sure what to do with this review. I ...

Dec. 13, 2017, 3:05 p.m. (2017-12-13 15:05:27 UTC) #3

ire

Dec. 14, 2017, 8:53 a.m. (2017-12-14 08:53:23 UTC) #4

On 2017/12/13 15:05:27, juliandoucette wrote:
> On 2017/12/13 15:04:07, juliandoucette wrote:
> > Not sure what to do with this review. I think we should convert it into a
> ticket
> > about improving the uninstall page?
> 
> (or create a corresponding ticket with blockers)

I don't think that will be necessary. When the other similar-styled pages are
created, that same design can be used for these pages. I don't think this
particular review would be necessary at that point either, except maybe for
reference. 

I'll close this review and if we ever need it we can always search for it.

Expand All Messages | Collapse All Messages