Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code
Issues
All Issues

Issue 29633564: Issue 5765 - Remove custom spacing units in help.eyeo.com (Closed)

Created:
Dec. 8, 2017, 9:55 a.m. by ire
Modified:
Dec. 11, 2017, 4:38 p.m.
Reviewers:
juliandoucette
Base URL:
https://hg.adblockplus.org/help.eyeo.com
Visibility:
Public.

Description

Issue 5765 - Remove custom spacing units in help.eyeo.com

Patch Set 1 #

Total comments: 5

Patch Set 2 : Rebased #

Patch Set 3 : Fixed issues with rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -66 lines) Patch
M static/src/scss/base/_variables.scss View 1 1 chunk +1 line, -5 lines 0 comments Download
M static/src/scss/components/_accordion.scss View 1 2 chunks +6 lines, -6 lines 0 comments Download
M static/src/scss/components/_article.scss View 1 2 chunks +5 lines, -5 lines 0 comments Download
M static/src/scss/components/_breadcrumb.scss View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
M static/src/scss/components/_browser-select.scss View 1 1 chunk +2 lines, -2 lines 0 comments Download
M static/src/scss/components/_card.scss View 1 1 chunk +3 lines, -3 lines 0 comments Download
M static/src/scss/components/_contact.scss View 1 1 chunk +12 lines, -11 lines 0 comments Download
M static/src/scss/components/_lists.scss View 1 1 chunk +2 lines, -2 lines 0 comments Download
M static/src/scss/components/_pre-icon.scss View 1 1 chunk +3 lines, -3 lines 0 comments Download
M static/src/scss/components/_search-form.scss View 1 2 chunks +5 lines, -5 lines 0 comments Download
M static/src/scss/content/_typography.scss View 1 1 chunk +1 line, -1 line 0 comments Download
M static/src/scss/layout/_body.scss View 1 2 1 chunk +7 lines, -7 lines 0 comments Download
M static/src/scss/layout/_footer.scss View 1 2 chunks +5 lines, -5 lines 0 comments Download
M static/src/scss/layout/_header.scss View 1 1 chunk +4 lines, -4 lines 0 comments Download
M static/src/scss/layout/_navbar.scss View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4
ire
Dec. 8, 2017, 9:55 a.m. (2017-12-08 09:55:37 UTC) #1
ire
Ready for review https://codereview.adblockplus.org/29633564/diff/29633565/static/scss/base/_variables.scss File static/scss/base/_variables.scss (right): https://codereview.adblockplus.org/29633564/diff/29633565/static/scss/base/_variables.scss#newcode68 static/scss/base/_variables.scss:68: $x-small-space: 0.5em; We should probably move ...
Dec. 8, 2017, 9:59 a.m. (2017-12-08 09:59:03 UTC) #2
juliandoucette
LGTM + Question (I probably didn't check this as thoroughly as I should. I'm trusting ...
Dec. 11, 2017, 3:21 p.m. (2017-12-11 15:21:40 UTC) #3
ire
Dec. 11, 2017, 4:34 p.m. (2017-12-11 16:34:12 UTC) #4 
On 2017/12/11 15:21:40, juliandoucette wrote:
> LGTM + Question
> 
> (I probably didn't check this as thoroughly as I should. I'm trusting you +
it's
> the preference that counts. We can fix anything left over when/if we find it.)

Ack.

https://codereview.adblockplus.org/29633564/diff/29633565/static/scss/compone...
File static/scss/components/_breadcrumb.scss (right):

https://codereview.adblockplus.org/29633564/diff/29633565/static/scss/compone...
static/scss/components/_breadcrumb.scss:48: top: $x-small-space - 0.05em; /*
Half height of li:after minus 0.05em */
On 2017/12/11 15:21:40, juliandoucette wrote:
> Why 0.05 em?

That's just the amount that I had to subtract to get it to align properly

Powered by Google App Engine
This is Rietveld