Issue 29643571: Issue 6203 - Fix rule-empty-line-before in stylelint-config-eyeo

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29643571: Issue 6203 - Fix rule-empty-line-before in stylelint-config-eyeo (Closed)

Created:
Dec. 18, 2017, 9:42 a.m. by ire

Modified:
Jan. 9, 2018, 8:09 a.m.

Reviewers:
tlucas, Erik, Sebastian Noack, Thomas Greiner, saroyanm, juliandoucette

Base URL:
https://hg.adblockplus.org/codingtools

Visibility:
Public.

Description

Issue 6203 - Fix rule-empty-line-before in stylelint-config-eyeo

Patch Set 1 #

Created: Dec. 18, 2017, 9:42 a.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	stylelint-config-eyeo/index.js	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 8

Expand All Messages | Collapse All Messages

tlucas

On 2017/12/18 13:29:18, juliandoucette wrote: > LGTM LGTM as far as the repository is concerned ...

Dec. 18, 2017, 2:18 p.m. (2017-12-18 14:18:57 UTC) #3

ire

Thanks @tclucas & @juliandoucette ! @Greiner: Would you like to take a look at this ...

Dec. 20, 2017, 12:08 p.m. (2017-12-20 12:08:26 UTC) #4

Thomas Greiner

On 2017/12/20 12:08:26, ire wrote: > @Greiner: Would you like to take a look at ...

Jan. 8, 2018, 12:36 p.m. (2018-01-08 12:36:42 UTC) #5

ire

@tclucas: Would you be able to help me commit&push this change? On 2018/01/08 12:36:42, Thomas ...

Jan. 8, 2018, 3:15 p.m. (2018-01-08 15:15:21 UTC) #6

tlucas

On 2018/01/08 15:15:21, ire wrote: > @tclucas: Would you be able to help me commit&push ...

Jan. 8, 2018, 3:26 p.m. (2018-01-08 15:26:01 UTC) #7

ire

Jan. 9, 2018, 8:09 a.m. (2018-01-09 08:09:36 UTC) #8

On 2018/01/08 15:26:01, tlucas wrote:
> On 2018/01/08 15:15:21, ire wrote:
> > @tclucas: Would you be able to help me commit&push this change?
> > 
> > On 2018/01/08 12:36:42, Thomas Greiner wrote:
> > > On 2017/12/20 12:08:26, ire wrote:
> > > > @Greiner: Would you like to take a look at this before it's pushed?
> > > 
> > > None of the semantics of the rules have changed so there's not much I
could
> > > contribute to this review.
> > > LGTM and sorry for the delayed response.
> > 
> > Thank you!
> 
> Sure, just mail me the patch ;)

Done. Thank you :)

Expand All Messages | Collapse All Messages