Issue 6201 - Fix the "Hide targeted messages?" notification

lib/antiadblockInit.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 30 matching lines @@
       subscription.disabled = !approved;
   }
 
   function addAntiAdblockNotification(subscription)
   {
     let urlFilters = [];
     for (let filter of subscription.filters)
     {
       if (filter instanceof ActiveFilter && filter.domains)
       {
-        for (let domain of filter.domains.keys())

[Wladimir Palant, 2017/12/19 11:36:05]

You need the value as well, so better:

  for (let [domain, included] of filter.domains)

[kzar, 2017/12/19 12:28:00]

Done.

+        for (let [domain, included] of filter.domains)
         {
           let urlFilter = "||" + domain + "^$document";
-          if (domain && filter.domains.has(domain) &&

[Wladimir Palant, 2017/12/19 11:36:05]

That's pointless, you already know that domain exists in filter.domains. This is
actually checking the value stored for the domain, meaning:

  if (domain && included && ...)

[kzar, 2017/12/19 12:28:00]

Whoops, Done.

-              urlFilters.indexOf(urlFilter) == -1)
+          if (domain && included && urlFilters.indexOf(urlFilter) == -1)
             urlFilters.push(urlFilter);
         }
       }
     }
     notification.urlFilters = urlFilters;
     Notification.addNotification(notification);
     Notification.addQuestionListener(notification.id, notificationListener);
   }
 
   function removeAntiAdblockNotification()
@@ skipping 17 matching lines @@
     if (url in FilterStorage.knownSubscriptions && subscription.disabled)
       addAntiAdblockNotification(subscription);
     else
       removeAntiAdblockNotification();
   }
 
   FilterNotifier.on("subscription.updated", onSubscriptionChange);
   FilterNotifier.on("subscription.removed", onSubscriptionChange);
   FilterNotifier.on("subscription.disabled", onSubscriptionChange);
 };