Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29643698: Issue 6201 - Fix the "Hide targeted messages?" notification (Closed)

Created:
Dec. 18, 2017, 3:32 p.m. by kzar
Modified:
Dec. 20, 2017, 2:13 p.m.
CC:
Sebastian Noack, Jon Sonesen, Thomas Greiner
Visibility:
Public.

Description

Issue 6201 - Fix the "Hide targeted messages?" notification

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed Wladimir's feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M lib/antiadblockInit.js View 1 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 6
kzar
Patch Set 1
Dec. 18, 2017, 3:33 p.m. (2017-12-18 15:33:07 UTC) #1
Wladimir Palant
https://codereview.adblockplus.org/29643698/diff/29643699/lib/antiadblockInit.js File lib/antiadblockInit.js (right): https://codereview.adblockplus.org/29643698/diff/29643699/lib/antiadblockInit.js#newcode51 lib/antiadblockInit.js:51: for (let domain of filter.domains.keys()) You need the value ...
Dec. 19, 2017, 11:36 a.m. (2017-12-19 11:36:05 UTC) #2
kzar
Patch Set 2 : Addressed Wladimir's feedback https://codereview.adblockplus.org/29643698/diff/29643699/lib/antiadblockInit.js File lib/antiadblockInit.js (right): https://codereview.adblockplus.org/29643698/diff/29643699/lib/antiadblockInit.js#newcode51 lib/antiadblockInit.js:51: for (let ...
Dec. 19, 2017, 12:28 p.m. (2017-12-19 12:28:00 UTC) #3
Wladimir Palant
LGTM
Dec. 19, 2017, 12:55 p.m. (2017-12-19 12:55:13 UTC) #4
kzar
(Adding Manvel as a reviewer since Thomas is on vacation.)
Dec. 19, 2017, 4:26 p.m. (2017-12-19 16:26:09 UTC) #5
saroyanm
Dec. 20, 2017, 1:30 p.m. (2017-12-20 13:30:04 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld