Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29645589: Noissue - Add page descriptions to website-defaults pages (Closed)

Created:
Dec. 20, 2017, 12:25 p.m. by ire
Modified:
Jan. 5, 2018, 7:48 a.m.
Reviewers:
juliandoucette
Base URL:
https://hg.adblockplus.org/website-defaults
Visibility:
Public.

Description

Background: I was testing out adding the wd styleguide to acceptableads, and it was throwing an error because the pages didn't have descriptions

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M pages/content.html View 1 chunk +1 line, -0 lines 0 comments Download
M pages/content-styleguide.md View 1 chunk +1 line, -0 lines 0 comments Download
M pages/developer-styleguide.html View 1 chunk +1 line, -0 lines 0 comments Download
M pages/forms/advanced.html View 1 chunk +1 line, -0 lines 0 comments Download
M pages/forms/basic.html View 1 chunk +1 line, -0 lines 0 comments Download
M pages/forms/buttons.html View 1 chunk +1 line, -0 lines 0 comments Download
M pages/grid.html View 1 chunk +1 line, -0 lines 0 comments Download
M pages/index.html View 1 chunk +1 line, -0 lines 0 comments Download
M pages/utilities.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5
ire
Dec. 20, 2017, 12:26 p.m. (2017-12-20 12:26:01 UTC) #1
juliandoucette
Is there a reason why none of these descriptions have periods?
Jan. 4, 2018, 1:45 a.m. (2018-01-04 01:45:00 UTC) #2
ire
On 2018/01/04 01:45:00, juliandoucette wrote: > Is there a reason why none of these descriptions ...
Jan. 4, 2018, 7:23 a.m. (2018-01-04 07:23:55 UTC) #3
juliandoucette
Jan. 4, 2018, 3:31 p.m. (2018-01-04 15:31:08 UTC) #4
juliandoucette
Jan. 4, 2018, 3:36 p.m. (2018-01-04 15:36:15 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld