Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29645600: Issue 6177 - overlaping header text in the sidebar (Closed)

Created:
Dec. 20, 2017, 1:49 p.m. by saroyanm
Modified:
Dec. 20, 2017, 3:13 p.m.
Reviewers:
ire
Visibility:
Public.

Description

Issue 6177 - overlaping header text in the sidebar

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M skin/desktop-options.css View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3
saroyanm
@Ire can you please have a look if you have chance, I did adjust the ...
Dec. 20, 2017, 1:52 p.m. (2017-12-20 13:52:32 UTC) #1
ire
On 2017/12/20 13:52:32, saroyanm wrote: > @Ire can you please have a look if you ...
Dec. 20, 2017, 2:44 p.m. (2017-12-20 14:44:59 UTC) #2
saroyanm
Dec. 20, 2017, 2:48 p.m. (2017-12-20 14:48:24 UTC) #3
On 2017/12/20 14:44:59, ire wrote:
> On 2017/12/20 13:52:32, saroyanm wrote:
> > @Ire can you please have a look if you have chance, 
> > I did adjust the sizes according to the Jeen's suggestion in the comment ->
> > https://issues.adblockplus.org/ticket/6177#comment:5 
> > After the review is ready, I'll also create a spec ticket to reflect the
> change
> > there as well.
> > 
> > There is another issue with the table status columns in the Advanced tab,
but
> > I'll address that separately, the ticket will come soon.
> 
> Seen. Your change LGTM, but I think we should have a tester (maybe @Shikitita
> since she reported it) test this change in all languages to make sure its
> enough.
Thanks I agree:
This was the longest text, but I have Ross CC-ed in the issue, I'll make the
description more general so he will test against other locales before making
this into the legacy build.

Powered by Google App Engine
This is Rietveld