Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(82)

Issue 29646589: Issue 6191 - Update frame structure for Chrome Web Store pages (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months ago by Manish Jethani
Modified:
3 months, 1 week ago
Reviewers:
Sebastian Noack, kzar
Base URL:
https://hg.adblockplus.org/adblockpluschrome/
Visibility:
Public.

Description

Issue 6191 - Update frame structure for Chrome Web Store pages

Patch Set 1 #

Total comments: 3

Patch Set 2 : Do not create URL object #

Total comments: 6

Patch Set 3 : Modify check #

Patch Set 4 : Combine checks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M ext/background.js View 1 2 3 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 11
Manish Jethani
4 months ago (2017-12-21 13:55:52 UTC) #1
Manish Jethani
Patch Set 1 The documentation for webRequest.onHeadersReceived [1] states that the event won't be dispatched ...
4 months ago (2017-12-21 13:59:52 UTC) #2
kzar
Sorry for being slow with this review as well. https://codereview.adblockplus.org/29646589/diff/29646590/ext/background.js File ext/background.js (right): https://codereview.adblockplus.org/29646589/diff/29646590/ext/background.js#newcode270 ext/background.js:270: ...
3 months, 2 weeks ago (2018-01-05 16:46:20 UTC) #3
Manish Jethani
Patch Set 2: Do not create URL object https://codereview.adblockplus.org/29646589/diff/29646590/ext/background.js File ext/background.js (right): https://codereview.adblockplus.org/29646589/diff/29646590/ext/background.js#newcode270 ext/background.js:270: url.href.startsWith("https://chrome.google.com/webstore/")) ...
3 months, 1 week ago (2018-01-12 07:25:03 UTC) #4
Manish Jethani
https://codereview.adblockplus.org/29646589/diff/29646590/ext/background.js File ext/background.js (right): https://codereview.adblockplus.org/29646589/diff/29646590/ext/background.js#newcode270 ext/background.js:270: url.href.startsWith("https://chrome.google.com/webstore/")) On 2018/01/12 07:25:03, Manish Jethani wrote: > So ...
3 months, 1 week ago (2018-01-12 07:31:58 UTC) #5
Manish Jethani
Also, looking at the Chrome Web Store, it's just a web app, so all the ...
3 months, 1 week ago (2018-01-12 07:32:59 UTC) #6
kzar
https://codereview.adblockplus.org/29646589/diff/29664555/ext/background.js File ext/background.js (left): https://codereview.adblockplus.org/29646589/diff/29664555/ext/background.js#oldcode266 ext/background.js:266: let url = new URL(details.url); On 2018/01/12 07:25:03, Manish ...
3 months, 1 week ago (2018-01-12 12:04:12 UTC) #7
Manish Jethani
Patch Set 3: Modify check https://codereview.adblockplus.org/29646589/diff/29664555/ext/background.js File ext/background.js (right): https://codereview.adblockplus.org/29646589/diff/29664555/ext/background.js#newcode267 ext/background.js:267: if (!url.startsWith("https:") && !url.startsWith("http:") ...
3 months, 1 week ago (2018-01-14 14:46:16 UTC) #8
kzar
https://codereview.adblockplus.org/29646589/diff/29664555/ext/background.js File ext/background.js (right): https://codereview.adblockplus.org/29646589/diff/29664555/ext/background.js#newcode267 ext/background.js:267: if (!url.startsWith("https:") && !url.startsWith("http:") || On 2018/01/14 14:46:15, Manish ...
3 months, 1 week ago (2018-01-15 10:31:12 UTC) #9
Manish Jethani
Patch Set 4: Combine checks https://codereview.adblockplus.org/29646589/diff/29664555/ext/background.js File ext/background.js (right): https://codereview.adblockplus.org/29646589/diff/29664555/ext/background.js#newcode267 ext/background.js:267: if (!url.startsWith("https:") && !url.startsWith("http:") ...
3 months, 1 week ago (2018-01-15 12:08:34 UTC) #10
kzar
3 months, 1 week ago (2018-01-15 12:35:32 UTC) #11
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5