Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29657623: Issue 6111 - Fix overflowing text on adblockplus.org/nl/features (Closed)

Created:
Jan. 5, 2018, 10 a.m. by ire
Modified:
Jan. 8, 2018, 3:13 p.m.
Reviewers:
juliandoucette
Base URL:
https://hg.adblockplus.org/web.adblockplus.org
Visibility:
Public.

Description

Issue 6111 - Fix overflowing text on adblockplus.org/nl/features

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M static/css/features.css View 1 chunk +19 lines, -0 lines 2 comments Download

Messages

Total messages: 3
ire
Jan. 5, 2018, 10 a.m. (2018-01-05 10:00:05 UTC) #1
ire
Ready for review https://codereview.adblockplus.org/29657623/diff/29657624/static/css/features.css File static/css/features.css (right): https://codereview.adblockplus.org/29657623/diff/29657624/static/css/features.css#newcode72 static/css/features.css:72: width: 130px; Auto-hyphenation wasn't working with ...
Jan. 5, 2018, 10:02 a.m. (2018-01-05 10:02:21 UTC) #2
juliandoucette
Jan. 8, 2018, 12:15 p.m. (2018-01-08 12:15:28 UTC) #3
LGTM

https://codereview.adblockplus.org/29657623/diff/29657624/static/css/features...
File static/css/features.css (right):

https://codereview.adblockplus.org/29657623/diff/29657624/static/css/features...
static/css/features.css:72: width: 130px;
On 2018/01/05 10:02:20, ire wrote:
> Auto-hyphenation wasn't working with BG. I decided that the simplest and least
> obstructive solution here would be to just increase the width of the container
> to fir the text.
> 
> Since (I assume) this page will be changed soon anyway, I figured we don't
> really need a longer-lasting solution (unless you have any better ideas?)

Acknowledged.

Powered by Google App Engine
This is Rietveld