Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(13)

Issue 29659594: Issue 6089 - Adjusted checkbox cut borders (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 10 months ago by saroyanm
Modified:
1 year, 10 months ago
Reviewers:
ire
Visibility:
Public.

Description

Issue 6089 - Adjusted checkbox cut borders

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M skin/icons/checkbox.svg View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 2
saroyanm
@Ire can you please have a look when you have a chance. https://codereview.adblockplus.org/29659594/diff/29659595/skin/icons/checkbox.svg File skin/icons/checkbox.svg ...
1 year, 10 months ago (2018-01-08 15:14:26 UTC) #1
ire
1 year, 10 months ago (2018-01-09 08:38:00 UTC) #2
LGTM

https://codereview.adblockplus.org/29659594/diff/29659595/skin/icons/checkbox...
File skin/icons/checkbox.svg (right):

https://codereview.adblockplus.org/29659594/diff/29659595/skin/icons/checkbox...
skin/icons/checkbox.svg:4: <rect width="17" height="17" fill="#077CA6"
stroke="#077CA6" rx="2" x=".5" y=".5" />
On 2018/01/08 15:14:26, saroyanm wrote:
> I adjusted the size to be consistent with the "off" button which appears to
fix
> the border issue.

Acknowledged.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5