Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(415)

Issue 29661564: Template out V8 and prepare for other JS engine implementations

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 months, 1 week ago by Oleksandr
Modified:
9 months, 1 week ago
Reviewers:
sergei, hub, Eric
Visibility:
Public.

Description

The idea here is to convert JsValue and JsEngine into templates, where the template argument is a list of actual implementation specific types. This way we can do template instantiation during the compile time, while also keeping the interface definitions generic. This is work in progress while actual Duktape implementation is not finished.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+222 lines, -124 lines) Patch
M include/AdblockPlus/JsEngine.h View 10 chunks +30 lines, -27 lines 0 comments Download
M include/AdblockPlus/JsValue.h View 3 chunks +68 lines, -14 lines 0 comments Download
M include/AdblockPlus/Platform.h View 2 chunks +7 lines, -2 lines 0 comments Download
M shell/src/GcCommand.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ConsoleJsObject.h View 1 chunk +11 lines, -1 line 0 comments Download
M src/FileSystemJsObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/GlobalJsObject.h View 1 chunk +13 lines, -1 line 0 comments Download
M src/GlobalJsObject.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/JsContext.h View 1 chunk +10 lines, -8 lines 0 comments Download
M src/JsContext.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/JsEngine.cpp View 12 chunks +28 lines, -26 lines 0 comments Download
M src/JsValue.cpp View 10 chunks +35 lines, -35 lines 0 comments Download
M src/Platform.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/WebRequestJsObject.h View 1 chunk +11 lines, -1 line 0 comments Download
M src/WebRequestJsObject.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5