Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(28)

Issue 29663680: Issue 6220 - add travis-ci configuration for adblockpluscore

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 1 day ago by sergei
Modified:
2 days, 14 hours ago
Reviewers:
tlucas, hub
CC:
kzar
Base URL:
github.com:adblockplus/adblockpluscore
Visibility:
Public.

Description

only linux and osx

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
A .travis.yml View 1 chunk +22 lines, -0 lines 4 comments Download

Messages

Total messages: 6
sergei
1 week, 1 day ago (2018-01-11 21:47:49 UTC) #1
sergei
Forgot to leave comments. https://codereview.adblockplus.org/29663680/diff/29663681/.travis.yml File .travis.yml (right): https://codereview.adblockplus.org/29663680/diff/29663681/.travis.yml#newcode1 .travis.yml:1: language: cpp The language is ...
1 week, 1 day ago (2018-01-11 21:53:13 UTC) #2
kzar
Same with this one, could you review instead of me Tristan?
4 days, 18 hours ago (2018-01-15 12:03:49 UTC) #3
tlucas
Hey there, sorry for the late reply. Please find the comment below. https://codereview.adblockplus.org/29663680/diff/29663681/.travis.yml File .travis.yml ...
2 days, 17 hours ago (2018-01-17 12:41:40 UTC) #4
sergei
https://codereview.adblockplus.org/29663680/diff/29663681/.travis.yml File .travis.yml (right): https://codereview.adblockplus.org/29663680/diff/29663681/.travis.yml#newcode22 .travis.yml:22: email: false On 2018/01/17 12:41:39, tlucas wrote: > Do ...
2 days, 16 hours ago (2018-01-17 14:25:31 UTC) #5
tlucas
2 days, 14 hours ago (2018-01-17 16:39:32 UTC) #6
On 2018/01/17 14:25:31, sergei wrote:
> https://codereview.adblockplus.org/29663680/diff/29663681/.travis.yml
> File .travis.yml (right):
> 
>
https://codereview.adblockplus.org/29663680/diff/29663681/.travis.yml#newcode22
> .travis.yml:22: email: false
> On 2018/01/17 12:41:39, tlucas wrote:
> > Do we not want to be notified about failed builds?
> Just would like to precise that it can be configured whether it's for failed
> builds or even always.
> > Also, FWIW we could add some sugar and notify #adblockplus about succeeded
> > builds ;)
> This looks attractive actually, perhaps we should add it, I modified the issue
> description.
> 
> IMO we should keep it silent for the beginning until we see that it is working
> smoothly and see that we really need such information. I have some experience
> with such notifications, usually e-mail notifications become a spam pretty
soon,
> so I would propose to disable them and drop a message in IRC channel.
> 
> In addition we should take into account the actual workflow, unfortunately we
> don't push too often to the main repository, and we are more or less aware
when
> it happens (at least I'm notified in IRC by corresponding keywords) and can
> track the CI status, on the other hand the default configuration should not
> bother IMO us nor the author of changes. Let's say I am a third party person
(or
> even I'm who I'm) and want to contribute, in order to do it I fork the repo,
> make some changes and before sending it to codereview I run CI for the fork,
and
> this CI should not send any e-mail to anybody but me (if I really want it) nor
> send anything to IRC.

Sounds reasonable to me - LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5