Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(75)

Issue 29663680: Issue 6220 - add travis-ci configuration for adblockpluscore (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months, 1 week ago by sergei
Modified:
2 months, 3 weeks ago
Reviewers:
hub, tlucas
CC:
kzar
Base URL:
github.com:adblockplus/adblockpluscore
Visibility:
Public.

Description

only linux and osx

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
A .travis.yml View 1 chunk +22 lines, -0 lines 4 comments Download

Messages

Total messages: 8
sergei
3 months, 1 week ago (2018-01-11 21:47:49 UTC) #1
sergei
Forgot to leave comments. https://codereview.adblockplus.org/29663680/diff/29663681/.travis.yml File .travis.yml (right): https://codereview.adblockplus.org/29663680/diff/29663681/.travis.yml#newcode1 .travis.yml:1: language: cpp The language is ...
3 months, 1 week ago (2018-01-11 21:53:13 UTC) #2
kzar
Same with this one, could you review instead of me Tristan?
3 months, 1 week ago (2018-01-15 12:03:49 UTC) #3
tlucas
Hey there, sorry for the late reply. Please find the comment below. https://codereview.adblockplus.org/29663680/diff/29663681/.travis.yml File .travis.yml ...
3 months, 1 week ago (2018-01-17 12:41:40 UTC) #4
sergei
https://codereview.adblockplus.org/29663680/diff/29663681/.travis.yml File .travis.yml (right): https://codereview.adblockplus.org/29663680/diff/29663681/.travis.yml#newcode22 .travis.yml:22: email: false On 2018/01/17 12:41:39, tlucas wrote: > Do ...
3 months, 1 week ago (2018-01-17 14:25:31 UTC) #5
tlucas
On 2018/01/17 14:25:31, sergei wrote: > https://codereview.adblockplus.org/29663680/diff/29663681/.travis.yml > File .travis.yml (right): > > https://codereview.adblockplus.org/29663680/diff/29663681/.travis.yml#newcode22 > ...
3 months, 1 week ago (2018-01-17 16:39:32 UTC) #6
sergei
kzar, I would like to land it, I think it will grow and shaped later ...
2 months, 3 weeks ago (2018-01-30 17:56:33 UTC) #7
kzar
2 months, 3 weeks ago (2018-01-31 10:23:45 UTC) #8
Well I don't have any experience configuring Travis but I can't see anything
obviously wrong. Happy for you guys to push it whenever you're happy with it
really, you both have more of an idea about this than me.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5