sitescripts/reports/bin/mailDigests.py - Issue 29664601: Issue 6212 - Don't create reports for type "other"

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: sitescripts/reports/bin/mailDigests.py

Issue 29664601: Issue 6212 - Don't create reports for type "other" (Closed) Base URL: https://hg.adblockplus.org/sitescripts/file/cd6f20a3aede

Patch Set: Created Jan. 12, 2018, 11:58 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: sitescripts/reports/bin/mailDigests.py

diff --git a/sitescripts/reports/bin/mailDigests.py b/sitescripts/reports/bin/mailDigests.py

index 4623fe02c1df19ca359f27256500a50e56d6d45b..01453678ad2245c3ef634f7e1d69240d99dee577 100644

--- a/sitescripts/reports/bin/mailDigests.py

+++ b/sitescripts/reports/bin/mailDigests.py

@@ -68,10 +68,6 @@ def scanReports():

# only to subscriptions with matching filters

if dbreport['type'] == 'false negative' or subscription.get('hasmatches', 0) > 0:

recipients.append(subscriptions[subscriptionID])

- elif interval != 'week':

- # Send type "other" to fake subscription - daily reports

- recipients.append(fakeSubscription)

- subscriptionID = fakeSubscription.get('url', 'unknown')

if len(recipients) == 0:

continue

« no previous file with comments | « no previous file | no next file » | no next file with comments »