Issue 29669631: Noissue - Zero size OwnedString should be INVALID

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29669631: Noissue - Zero size OwnedString should be INVALID (Closed)

Created:
Jan. 15, 2018, 10:24 p.m. by hub

Modified:
Jan. 16, 2018, 1:09 p.m.

Reviewers:
sergei

Base URL:
https://hg.adblockplus.org/adblockpluscore/

Visibility:
Public.

Description

Noissue - Zero size OwnedString should be INVALID

Patch Set 1 #

Created: Jan. 15, 2018, 10:24 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	compiled/String.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

hub

Split out from https://codereview.adblockplus.org/29587914/

Jan. 15, 2018, 10:25 p.m. (2018-01-15 22:25:10 UTC) #2

sergei

Jan. 16, 2018, 12:04 p.m. (2018-01-16 12:04:08 UTC) #3

LGTM

I wonder whether we should actually check all constructors and ensure that when
someone passes something meaningful even u""_str it's a valid string with zero
length, but when e.g. a pointer to the buffer is nullptr then it's an invalid
string.

Expand All Messages | Collapse All Messages