Issue 29670635: Issue 5844 - Remove redundant parentheses in abpssembly

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29670635: Issue 5844 - Remove redundant parentheses in abpssembly (Closed)

Created:
Jan. 16, 2018, 5:58 p.m. by rosie

Modified:
Jan. 25, 2018, 7:29 p.m.

Reviewers:
Sebastian Noack, tlucas

CC:
Vasily Kuznetsov

Base URL:
https://hg.adblockplus.org/abpssembly/

Visibility:
Public.

Description

Remove redundant parentheses flagged by the new flake8 rule. I tested each modification against the original using pydiff, and the resulting bytecode is identical. Edit: Closing this issue. It should be merged with the changes in sitescripts: https://codereview.adblockplus.org/29670611/

Patch Set 1 #

Created: Jan. 16, 2018, 5:58 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+51 lines, -51 lines)			Patch
M	sitescripts/crashes/web/submitCrash.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sitescripts/extensions/utils.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sitescripts/formmail/web/formmail2.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sitescripts/notifications/parser.py	View	1 chunk	+8 lines, -8 lines	0 comments	Download
M	sitescripts/reports/bin/mailDigests.py	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	sitescripts/reports/bin/parseNewReports.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sitescripts/subscriptions/bin/generateReport.py	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	sitescripts/subscriptions/bin/updateStatusPage.py	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	sitescripts/subscriptions/knownIssuesParser.py	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	sitescripts/subscriptions/subscriptionParser.py	View	3 chunks	+10 lines, -10 lines	0 comments	Download
M	sitescripts/subscriptions/web/fallback.py	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	sitescripts/templateFilters.py	View	1 chunk	+12 lines, -12 lines	0 comments	Download
M	sitescripts/urlfixer/web/submitData.py	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	sitescripts/utils.py	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Sebastian Noack

Jan. 17, 2018, 12:53 a.m. (2018-01-17 00:53:01 UTC) #2

I guess this patch is for abpsemmbly? It would be helpful if you could add the
repository names to the review titles.

Are there any differences between this patch and the one for sitescripts
(https://codereview.adblockplus.org/29670611/)? At least the number of changed
lines seems to be the same. If there are no differences, I suggest to delete
this review, and merge the other patch in both repositories, once it passed
review.

Expand All Messages | Collapse All Messages