Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29670651: Issue 5844 - Remove redundant parentheses in cms (Closed)

Created:
Jan. 16, 2018, 6:10 p.m. by rosie
Modified:
Jan. 26, 2018, 2:44 a.m.
CC:
tlucas
Base URL:
https://hg.adblockplus.org/cms/
Visibility:
Public.

Description

Remove redundant parentheses flagged by the new flake8 rule. I tested each modification against the original using pydiff, and the resulting bytecode is identical.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed indentation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M cms/bin/generate_static_pages.py View 1 1 chunk +2 lines, -2 lines 0 comments Download
M cms/converters.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5
rosie
Jan. 16, 2018, 6:10 p.m. (2018-01-16 18:10:33 UTC) #1
Sebastian Noack
https://codereview.adblockplus.org/29670651/diff/29670652/cms/bin/generate_static_pages.py File cms/bin/generate_static_pages.py (right): https://codereview.adblockplus.org/29670651/diff/29670652/cms/bin/generate_static_pages.py#newcode130 cms/bin/generate_static_pages.py:130: 'See "hg help revisions" for details.', The indentation is ...
Jan. 17, 2018, 12:47 a.m. (2018-01-17 00:47:17 UTC) #2
rosie
https://codereview.adblockplus.org/29670651/diff/29670652/cms/bin/generate_static_pages.py File cms/bin/generate_static_pages.py (right): https://codereview.adblockplus.org/29670651/diff/29670652/cms/bin/generate_static_pages.py#newcode130 cms/bin/generate_static_pages.py:130: 'See "hg help revisions" for details.', On 2018/01/17 00:47:17, ...
Jan. 25, 2018, 7:09 p.m. (2018-01-25 19:09:26 UTC) #3
Sebastian Noack
LGTM
Jan. 25, 2018, 7:19 p.m. (2018-01-25 19:19:20 UTC) #4
Vasily Kuznetsov
Jan. 25, 2018, 7:42 p.m. (2018-01-25 19:42:49 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld