Noissue - Remove bare exception from test case

patchconv/tests/test_rietveld_to_git.py

 # This file is part of Adblock Plus <https://adblockplus.org/>,
 # Copyright (C) 2006-present eyeo GmbH
 #
 # Adblock Plus is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License version 3 as
 # published by the Free Software Foundation.
 #
 # Adblock Plus is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 # GNU General Public License for more details.
 #
 # You should have received a copy of the GNU General Public License
 # along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
 
 from __future__ import print_function, unicode_literals
 
 import os
 import subprocess
 try:
     from StringIO import StringIO
-except Exception:

[Sebastian Noack, 2018/01/17 00:41:42]

Where possible we should rather catch the specific exception that is to be
expected, so that if anything else goes wrong unexpectedly, we get aware of it
and can fix it properly. Here that is ImportError.

[rosie, 2018/01/25 19:00:13]

Done.

+except ImportError:
     from io import StringIO
 
 import mock
 import pytest
 
 import patchconv
 
 TEST_DIR = os.path.dirname(__file__)
 
 
@@ skipping 42 matching lines @@
 --- a/README.txt
 '''
     out, err = process.communicate(input=in_patch.encode('ascii'))
     assert out == expect.encode('ascii')
 
     stdin = StringIO(in_patch)
     stdout = StringIO()
     with mock.patch('sys.stdin', stdin), mock.patch('sys.stdout', stdout):
         patchconv.main()
     assert stdout.getvalue() == expect