Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29670655: Noissue - Remove bare exception from test case (Closed)

Created:
Jan. 16, 2018, 6:53 p.m. by rosie
Modified:
Jan. 26, 2018, 2:42 a.m.
CC:
tlucas
Base URL:
https://hg.adblockplus.org/codingtools/
Visibility:
Public.

Description

Noissue - Remove bare exception from test case

Patch Set 1 #

Total comments: 2

Patch Set 2 : Changed Exception to ImportError #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M patchconv/tests/test_rietveld_to_git.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
rosie
Jan. 16, 2018, 6:53 p.m. (2018-01-16 18:53:06 UTC) #1
Sebastian Noack
https://codereview.adblockplus.org/29670655/diff/29670656/patchconv/tests/test_rietveld_to_git.py File patchconv/tests/test_rietveld_to_git.py (right): https://codereview.adblockplus.org/29670655/diff/29670656/patchconv/tests/test_rietveld_to_git.py#newcode22 patchconv/tests/test_rietveld_to_git.py:22: except Exception: Where possible we should rather catch the ...
Jan. 17, 2018, 12:41 a.m. (2018-01-17 00:41:42 UTC) #2
rosie
https://codereview.adblockplus.org/29670655/diff/29670656/patchconv/tests/test_rietveld_to_git.py File patchconv/tests/test_rietveld_to_git.py (right): https://codereview.adblockplus.org/29670655/diff/29670656/patchconv/tests/test_rietveld_to_git.py#newcode22 patchconv/tests/test_rietveld_to_git.py:22: except Exception: On 2018/01/17 00:41:42, Sebastian Noack wrote: > ...
Jan. 25, 2018, 7 p.m. (2018-01-25 19:00:14 UTC) #3
Sebastian Noack
LGTM
Jan. 25, 2018, 7:11 p.m. (2018-01-25 19:11:21 UTC) #4
Vasily Kuznetsov
Jan. 25, 2018, 7:38 p.m. (2018-01-25 19:38:52 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld