Unified Diff: patchconv/tests/test_rietveld_to_git.py
Issue 29670655:
Noissue - Remove bare exception from test case (Closed)
Base URL: https://hg.adblockplus.org/codingtools/
Patch Set:
Created Jan. 16, 2018, 6:53 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« no previous file
|
no next file »
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: patchconv/tests/test_rietveld_to_git.py |
| =================================================================== |
| --- a/patchconv/tests/test_rietveld_to_git.py |
| +++ b/patchconv/tests/test_rietveld_to_git.py |
| @@ -19,7 +19,7 @@ |
| import subprocess |
| try: |
| from StringIO import StringIO |
| -except: |
| +except Exception: |
|
Sebastian Noack
2018/01/17 00:41:42
Where possible we should rather catch the specific
rosie
2018/01/25 19:00:13
Done.
|
| from io import StringIO |
| import mock |
« no previous file with comments
|
« no previous file
|
no next file »
|
no next file with comments »
