Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: build.py

Issue 29670676: Issue 5844 - Remove redundant parentheses in buildtools (Closed) Base URL: https://hg.adblockplus.org/buildtools/
Left Patch Set: Created Jan. 16, 2018, 11:43 p.m.
Right Patch Set: Fixed indentation and (previously ignored) A111 error in packagerChrome.py Created Jan. 25, 2018, 7:20 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | ensure_dependencies.py » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 # This Source Code Form is subject to the terms of the Mozilla Public 1 # This Source Code Form is subject to the terms of the Mozilla Public
2 # License, v. 2.0. If a copy of the MPL was not distributed with this 2 # License, v. 2.0. If a copy of the MPL was not distributed with this
3 # file, You can obtain one at http://mozilla.org/MPL/2.0/. 3 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
4 4
5 import argparse 5 import argparse
6 import logging 6 import logging
7 import os 7 import os
8 import re 8 import re
9 import shutil 9 import shutil
10 import subprocess 10 import subprocess
(...skipping 110 matching lines...) Expand 10 before | Expand all | Expand 10 after
121 121
122 build_available_subcommands._result = None 122 build_available_subcommands._result = None
123 123
124 124
125 @argparse_command( 125 @argparse_command(
126 valid_platforms={'chrome', 'gecko', 'edge'}, 126 valid_platforms={'chrome', 'gecko', 'edge'},
127 arguments=( 127 arguments=(
128 make_argument( 128 make_argument(
129 '-b', '--build-num', dest='build_num', 129 '-b', '--build-num', dest='build_num',
130 help='Use given build number (if omitted the build number will ' 130 help='Use given build number (if omitted the build number will '
131 'be retrieved from Mercurial)'), 131 'be retrieved from Mercurial)'),
Sebastian Noack 2018/01/17 00:44:54 The indentation is off by one. Please align subseq
rosie 2018/01/25 19:22:19 Done.
132 make_argument( 132 make_argument(
133 '-k', '--key', dest='key_file', 133 '-k', '--key', dest='key_file',
134 help='File containing private key and certificates required to ' 134 help='File containing private key and certificates required to '
135 'sign the package'), 135 'sign the package'),
136 make_argument( 136 make_argument(
137 '-r', '--release', action='store_true', 137 '-r', '--release', action='store_true',
138 help='Create a release build'), 138 help='Create a release build'),
139 make_argument('output_file', nargs='?') 139 make_argument('output_file', nargs='?')
140 ) 140 )
141 ) 141 )
(...skipping 237 matching lines...) Expand 10 before | Expand all | Expand 10 after
379 if build_available_subcommands(base_dir): 379 if build_available_subcommands(base_dir):
380 MAIN_PARSER.set_defaults(base_dir=base_dir) 380 MAIN_PARSER.set_defaults(base_dir=base_dir)
381 381
382 # If no args are provided, this module is run directly from the command 382 # If no args are provided, this module is run directly from the command
383 # line. argparse will take care of consuming sys.argv. 383 # line. argparse will take care of consuming sys.argv.
384 arguments = MAIN_PARSER.parse_args(args if len(args) > 0 else None) 384 arguments = MAIN_PARSER.parse_args(args if len(args) > 0 else None)
385 385
386 function = arguments.function 386 function = arguments.function
387 del arguments.function 387 del arguments.function
388 function(**vars(arguments)) 388 function(**vars(arguments))
LEFTRIGHT

Powered by Google App Engine
This is Rietveld