Issue 29670676: Issue 5844 - Remove redundant parentheses in buildtools

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29670676: Issue 5844 - Remove redundant parentheses in buildtools (Closed)

Created:
Jan. 16, 2018, 11:43 p.m. by rosie

Modified:
Jan. 26, 2018, 2:44 a.m.

Reviewers:
Sebastian Noack, Vasily Kuznetsov

CC:
tlucas

Base URL:
https://hg.adblockplus.org/buildtools/

Visibility:
Public.

Description

Remove redundant parentheses flagged by the new flake8 rule. I tested each modification against the original using pydiff, and the resulting bytecode is identical.

Patch Set 2 : Fixed indentation and (previously ignored) A111 error in packagerChrome.py #

Created: Jan. 25, 2018, 7:20 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -13 lines)			Patch
M	build.py	View	1	2 chunks	+8 lines, -8 lines	0 comments	Download
M	ensure_dependencies.py	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	localeTools.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	packagerChrome.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tox.ini	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

Sebastian Noack

https://codereview.adblockplus.org/29670676/diff/29670677/build.py File build.py (right): https://codereview.adblockplus.org/29670676/diff/29670677/build.py#newcode131 build.py:131: 'be retrieved from Mercurial)'), The indentation is off by ...

Jan. 17, 2018, 12:44 a.m. (2018-01-17 00:44:54 UTC) #2

Sebastian Noack

Also there is one more A111 in packagerChrome.py, line 57, which is currently ignored in ...

Jan. 17, 2018, 1:14 a.m. (2018-01-17 01:14:58 UTC) #3

rosie

Hi Sebastian, I fixed the indentation in build.py, the A111 error in packagerChrome.py, and the ...

Jan. 25, 2018, 7:22 p.m. (2018-01-25 19:22:20 UTC) #4

LGTM

Expand All Messages | Collapse All Messages