packagerChrome.py - Issue 29670676: Issue 5844 - Remove redundant parentheses in buildtools

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: packagerChrome.py

Issue 29670676: Issue 5844 - Remove redundant parentheses in buildtools (Closed) Base URL: https://hg.adblockplus.org/buildtools/

Patch Set: Fixed indentation and (previously ignored) A111 error in packagerChrome.py Created Jan. 25, 2018, 7:20 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: packagerChrome.py

===================================================================

--- a/packagerChrome.py

+++ b/packagerChrome.py

@@ -54,7 +54,7 @@

magic = None

if magic != '\x89PNG\r\n\x1a\n':

raise Exception(filename + ' is no valid PNG.')

- if(width != height):

+ if width != height:

print >>sys.stderr, 'Warning: %s size is %ix%i, icon should be square' % (filename, width, height)

icons[width] = filename

return icons

« no previous file with comments | « localeTools.py ('k') | tox.ini » ('j') | no next file with comments »