Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29671566: Issue 6283 - Adjust text highlight and text select handle colors (Closed)

Created:
Jan. 17, 2018, 9:27 a.m. by jens
Modified:
Jan. 18, 2018, 1:15 p.m.
Reviewers:
anton, diegocarloslima
Visibility:
Public.

Description

Issue 6283 - Adjust text highlight and text select handle colors

Patch Set 1 : #

Total comments: 2

Messages

Total messages: 5
jens
Jan. 17, 2018, 9:32 a.m. (2018-01-17 09:32:10 UTC) #1
anton
https://codereview.adblockplus.org/29671566/diff/29671578/mobile/android/themes/geckoview/defines.css File mobile/android/themes/geckoview/defines.css (right): https://codereview.adblockplus.org/29671566/diff/29671578/mobile/android/themes/geckoview/defines.css#newcode2 mobile/android/themes/geckoview/defines.css:2: /* Adjust text highlight color. See https://issues.adblockplus.org/ticket/6283 */ Shouldn't ...
Jan. 17, 2018, 12:55 p.m. (2018-01-17 12:55:14 UTC) #2
jens
https://codereview.adblockplus.org/29671566/diff/29671578/mobile/android/themes/geckoview/defines.css File mobile/android/themes/geckoview/defines.css (right): https://codereview.adblockplus.org/29671566/diff/29671578/mobile/android/themes/geckoview/defines.css#newcode2 mobile/android/themes/geckoview/defines.css:2: /* Adjust text highlight color. See https://issues.adblockplus.org/ticket/6283 */ On ...
Jan. 18, 2018, 10:34 a.m. (2018-01-18 10:34:13 UTC) #3
diegocarloslima
On 2018/01/18 10:34:13, jens wrote: > https://codereview.adblockplus.org/29671566/diff/29671578/mobile/android/themes/geckoview/defines.css > File mobile/android/themes/geckoview/defines.css (right): > > https://codereview.adblockplus.org/29671566/diff/29671578/mobile/android/themes/geckoview/defines.css#newcode2 > ...
Jan. 18, 2018, 12:18 p.m. (2018-01-18 12:18:06 UTC) #4
anton
Jan. 18, 2018, 12:22 p.m. (2018-01-18 12:22:55 UTC) #5
On 2018/01/18 12:18:06, diegocarloslima wrote:
> On 2018/01/18 10:34:13, jens wrote:
> >
>
https://codereview.adblockplus.org/29671566/diff/29671578/mobile/android/them...
> > File mobile/android/themes/geckoview/defines.css (right):
> > 
> >
>
https://codereview.adblockplus.org/29671566/diff/29671578/mobile/android/them...
> > mobile/android/themes/geckoview/defines.css:2: /* Adjust text highlight
color.
> > See https://issues.adblockplus.org/ticket/6283 */
> > On 2018/01/17 12:55:13, anton wrote:
> > > Shouldn't we replace tabs with spaces?
> > 
> > I am not sure. Mozilla was using tabs and I just kept the formatting as it
> was.
> > Let's see what diego thinks.
> 
> I particularly prefere spaces, but since the whole file is indented with tabs,
I
> think we should stick with it. We usually stick to the default code style on
> Mozilla files, we only apply our code style in our own files. Given that, LGTM

LGTM

Powered by Google App Engine
This is Rietveld