Issue 6283 - Adjust text highlight and text select handle colors

Issue 6283 - Adjust text highlight and text select handle colors

[anton, 2018-01-17 12:55:14]

https://codereview.adblockplus.org/29671566/diff/29671578/mobile/android/them...
File mobile/android/themes/geckoview/defines.css (right):

https://codereview.adblockplus.org/29671566/diff/29671578/mobile/android/them...
mobile/android/themes/geckoview/defines.css:2: /* Adjust text highlight color.
See https://issues.adblockplus.org/ticket/6283 */
Shouldn't we replace tabs with spaces?

[jens, 2018-01-18 10:34:13]

https://codereview.adblockplus.org/29671566/diff/29671578/mobile/android/them...
File mobile/android/themes/geckoview/defines.css (right):

https://codereview.adblockplus.org/29671566/diff/29671578/mobile/android/them...
mobile/android/themes/geckoview/defines.css:2: /* Adjust text highlight color.
See https://issues.adblockplus.org/ticket/6283 */
On 2018/01/17 12:55:13, anton wrote:
> Shouldn't we replace tabs with spaces?

I am not sure. Mozilla was using tabs and I just kept the formatting as it was.
Let's see what diego thinks.

[diegocarloslima, 2018-01-18 12:18:06]

On 2018/01/18 10:34:13, jens wrote:
>
https://codereview.adblockplus.org/29671566/diff/29671578/mobile/android/them...
> File mobile/android/themes/geckoview/defines.css (right):
> 
>
https://codereview.adblockplus.org/29671566/diff/29671578/mobile/android/them...
> mobile/android/themes/geckoview/defines.css:2: /* Adjust text highlight color.
> See https://issues.adblockplus.org/ticket/6283 */
> On 2018/01/17 12:55:13, anton wrote:
> > Shouldn't we replace tabs with spaces?
> 
> I am not sure. Mozilla was using tabs and I just kept the formatting as it
was.
> Let's see what diego thinks.

I particularly prefere spaces, but since the whole file is indented with tabs, I
think we should stick with it. We usually stick to the default code style on
Mozilla files, we only apply our code style in our own files. Given that, LGTM

[anton, 2018-01-18 12:22:55]

On 2018/01/18 12:18:06, diegocarloslima wrote:
> On 2018/01/18 10:34:13, jens wrote:
> >
>
https://codereview.adblockplus.org/29671566/diff/29671578/mobile/android/them...
> > File mobile/android/themes/geckoview/defines.css (right):
> > 
> >
>
https://codereview.adblockplus.org/29671566/diff/29671578/mobile/android/them...
> > mobile/android/themes/geckoview/defines.css:2: /* Adjust text highlight
color.
> > See https://issues.adblockplus.org/ticket/6283 */
> > On 2018/01/17 12:55:13, anton wrote:
> > > Shouldn't we replace tabs with spaces?
> > 
> > I am not sure. Mozilla was using tabs and I just kept the formatting as it
> was.
> > Let's see what diego thinks.
> 
> I particularly prefere spaces, but since the whole file is indented with tabs,
I
> think we should stick with it. We usually stick to the default code style on
> Mozilla files, we only apply our code style in our own files. Given that, LGTM

LGTM