third_party/libadblockplus_android/BUILD.gn - Issue 29674558: Issue 6286 - Remove common scripts duplicating

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: third_party/libadblockplus_android/BUILD.gn

Issue 29674558: Issue 6286 - Remove common scripts duplicating (Closed)

Patch Set: Created Jan. 19, 2018, 8:03 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: third_party/libadblockplus_android/BUILD.gn

diff --git a/third_party/libadblockplus_android/BUILD.gn b/third_party/libadblockplus_android/BUILD.gn

index 3a9c7d7145273d9ccb9f57f55d28e9243230481c..63d1735f6abc10ce5e2869009bcdf34463253984 100644

--- a/third_party/libadblockplus_android/BUILD.gn

+++ b/third_party/libadblockplus_android/BUILD.gn

@@ -65,7 +65,7 @@ _libadblockplus_binaries_dir = "${target_out_dir}/libadblockplus-binaries"

_abs_libadblockplus_binaries_dir = rebase_path("${_libadblockplus_binaries_dir}")

action("clear") {

- script = "delete_dir.py"

+ script = "//third_party/libadblockplus_common/delete_dir.py"

args = [

"${_cwd}/libadblockplus-android/.externalNativeBuild"

]

@@ -89,7 +89,7 @@ action("make") {

":copy_libv8_libbase",

]

- script = "subproc.py"

+ script = "//third_party/libadblockplus_common/subproc.py"

inputs = [

]

@@ -131,10 +131,10 @@ _abs_prebuild_dir = rebase_path("${_prebuild_dir}")

# to generate .info and then rerun 'ninja' again to build with existing .info file.

#print("Prebuilding libadblockplus-android to ${_abs_prebuild_dir}")

-exec_script("delete_dir.py", [

+exec_script("//third_party/libadblockplus_common/delete_dir.py", [

"${_cwd}/libadblockplus-android/.externalNativeBuild"

])

-exec_script("subproc.py", [

+exec_script("//third_party/libadblockplus_common/subproc.py", [

"${_cwd}/gradlew", "clean", "assembleAbi_${target_cpu}Release", ":libadblockplus-android-settings:assembleRelease",

# cwd