Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code
Issues
All Issues

Issue 29674558: Issue 6286 - Remove common scripts duplicating (Closed)

Created:
Jan. 19, 2018, 8:03 a.m. by anton
Modified:
Jan. 19, 2018, 11:35 a.m.
CC:
René Jeschke
Visibility:
Public.

Description

Issue 6286 - Remove common scripts duplicating

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -118 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libadblockplus/BUILD.gn View 1 chunk +1 line, -1 line 2 comments Download
D third_party/libadblockplus/delete_dir.py View 1 chunk +0 lines, -19 lines 0 comments Download
D third_party/libadblockplus/subproc.py View 1 chunk +0 lines, -38 lines 0 comments Download
M third_party/libadblockplus_android/BUILD.gn View 3 chunks +4 lines, -4 lines 0 comments Download
D third_party/libadblockplus_android/delete_dir.py View 1 chunk +0 lines, -19 lines 0 comments Download
D third_party/libadblockplus_android/subproc.py View 1 chunk +0 lines, -38 lines 0 comments Download
A + third_party/libadblockplus_common/delete_dir.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/libadblockplus_common/subproc.py View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 5
anton
Jan. 19, 2018, 8:04 a.m. (2018-01-19 08:04:24 UTC) #1
sergei
https://codereview.adblockplus.org/29674558/diff/29674559/third_party/libadblockplus/BUILD.gn File third_party/libadblockplus/BUILD.gn (right): https://codereview.adblockplus.org/29674558/diff/29674559/third_party/libadblockplus/BUILD.gn#newcode3 third_party/libadblockplus/BUILD.gn:3: script = "//third_party/libadblockplus_common/subproc.py" Does "//" has a special meaning ...
Jan. 19, 2018, 9:01 a.m. (2018-01-19 09:01:57 UTC) #2
anton
On 2018/01/19 09:01:57, sergei wrote: > https://codereview.adblockplus.org/29674558/diff/29674559/third_party/libadblockplus/BUILD.gn > File third_party/libadblockplus/BUILD.gn (right): > > https://codereview.adblockplus.org/29674558/diff/29674559/third_party/libadblockplus/BUILD.gn#newcode3 > ...
Jan. 19, 2018, 9:10 a.m. (2018-01-19 09:10:20 UTC) #3
jens
On 2018/01/19 09:10:20, anton wrote: > On 2018/01/19 09:01:57, sergei wrote: > > > https://codereview.adblockplus.org/29674558/diff/29674559/third_party/libadblockplus/BUILD.gn ...
Jan. 19, 2018, 9:11 a.m. (2018-01-19 09:11:52 UTC) #4
sergei
Jan. 19, 2018, 9:38 a.m. (2018-01-19 09:38:33 UTC) #5 
LGTM

https://codereview.adblockplus.org/29674558/diff/29674559/third_party/libadbl...
File third_party/libadblockplus/BUILD.gn (right):

https://codereview.adblockplus.org/29674558/diff/29674559/third_party/libadbl...
third_party/libadblockplus/BUILD.gn:3: script =
"//third_party/libadblockplus_common/subproc.py"
On 2018/01/19 09:01:57, sergei wrote:
> Does "//" has a special meaning here? I would expect it to be an absolute
path,
> but there is likely nothing at such location.

Acknowledged.

Powered by Google App Engine
This is Rietveld